Zoom use pro accounts first #165
Conversation
Add new method to create account from user instead of just email, so type is preserved This is so we can filter by account type later in the process I could filter here, in getting accounts from users, but that restricts the number of available sessions This way I can filter when returning availableSessions, giving priority to pro users but falling back to basic user accounts if needed
|
This is working locally; I've logged the
[EDIT: disregard. the below error has been found and fixed]
|
We have at least one reported instance of a meeting being created with an account that was already in use There is not enough data to debug how or why this happened In the unlikely but I guess technically feasible event that this was caused by the user starting a meeting Just after the live meetings check had been made, this change would improve chances of avoiding the problem happening again
|
This also addresses Issue #127 -- though I'm honestly not sure if it really closes it. Thoughts? |
Add missing closing paran to accountMeetings Array from line Move question mark in Account type optional param definition
Prvious commits were all made with prettier disabled, because I had not yet figured out what syntax error was breaking linting The commit with the syntax error fixes is easier to read without also including all the linting, so I disabled prettier on that commit as well Thus, the linting for the last few commits all in one swell foop
As a warning to future us, if we scale to having more than 30 zoom user accounts
Note that there is a time limit, and offer workarounds Inform them instead of annoying them... hopefully
|
Re: issue 127, I'm okay with letting that one close with this, unless and until we run into it again. |
This is replaced by accountFromUser Also make Account type param mandatory
There was a problem hiding this comment.
Alright, ready for re-review @Shadowfiend - thanks for the notes!
Closes #164
Closes #127
This filters
availableSessionsinto separate arrays for accounts of Basic vs Pro user type.It uses Basic accounts only if no sessions are available with Pro accounts. When a basic account is used, the Heimdall zoom link reply includes messaging about the time limit.