-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom use pro accounts first #165
Merged
Merged
Commits on Nov 11, 2019
-
Add type to Account based on UserType
Add new method to create account from user instead of just email, so type is preserved This is so we can filter by account type later in the process I could filter here, in getting accounts from users, but that restricts the number of available sessions This way I can filter when returning availableSessions, giving priority to pro users but falling back to basic user accounts if needed
Configuration menu - View commit details
-
Copy full SHA for 72f163f - Browse repository at this point
Copy the full SHA 72f163fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ddb9409 - Browse repository at this point
Copy the full SHA ddb9409View commit details -
Move live meeting check to the end of the checks
We have at least one reported instance of a meeting being created with an account that was already in use There is not enough data to debug how or why this happened In the unlikely but I guess technically feasible event that this was caused by the user starting a meeting Just after the live meetings check had been made, this change would improve chances of avoiding the problem happening again
Configuration menu - View commit details
-
Copy full SHA for 825c185 - Browse repository at this point
Copy the full SHA 825c185View commit details -
Add missing closing paran to accountMeetings Array from line Move question mark in Account type optional param definition
Configuration menu - View commit details
-
Copy full SHA for 0067e80 - Browse repository at this point
Copy the full SHA 0067e80View commit details -
Prvious commits were all made with prettier disabled, because I had not yet figured out what syntax error was breaking linting The commit with the syntax error fixes is easier to read without also including all the linting, so I disabled prettier on that commit as well Thus, the linting for the last few commits all in one swell foop
Configuration menu - View commit details
-
Copy full SHA for abc8746 - Browse repository at this point
Copy the full SHA abc8746View commit details -
As a warning to future us, if we scale to having more than 30 zoom user accounts
Configuration menu - View commit details
-
Copy full SHA for 771463a - Browse repository at this point
Copy the full SHA 771463aView commit details
Commits on Nov 12, 2019
-
Add user facing messaging if basic acct used
Note that there is a time limit, and offer workarounds Inform them instead of annoying them... hopefully
Configuration menu - View commit details
-
Copy full SHA for 18cfc33 - Browse repository at this point
Copy the full SHA 18cfc33View commit details -
Remove obsolete accountForEmail
This is replaced by accountFromUser Also make Account type param mandatory
Configuration menu - View commit details
-
Copy full SHA for 0ff90d3 - Browse repository at this point
Copy the full SHA 0ff90d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 602f59d - Browse repository at this point
Copy the full SHA 602f59dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2270c12 - Browse repository at this point
Copy the full SHA 2270c12View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.