Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom use pro accounts first #165

Merged
merged 10 commits into from
Nov 14, 2019
Merged

Zoom use pro accounts first #165

merged 10 commits into from
Nov 14, 2019

Commits on Nov 11, 2019

  1. Add type to Account based on UserType

    Add new method to create account from user instead of just email, so
    type is preserved
    
    This is so we can filter by account type later in the process
    I could filter here, in getting accounts from users, but that
    restricts the number of available sessions
    
    This way I can filter when returning availableSessions, giving
    priority to pro users but falling back to basic user accounts if
    needed
    kb0rg committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    72f163f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddb9409 View commit details
    Browse the repository at this point in the history
  3. Move live meeting check to the end of the checks

    We have at least one reported instance of a meeting being created
    with an account that was already in use
    There is not enough data to debug how or why this happened
    In the unlikely but I guess technically feasible event that this was
    caused by the user starting a meeting Just after the live meetings
    check had been made, this change would improve chances of avoiding
    the problem happening again
    kb0rg committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    825c185 View commit details
    Browse the repository at this point in the history
  4. Fix a couple syntax errors

    Add missing closing paran to accountMeetings Array from line
    Move question mark in Account type optional param definition
    kb0rg committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    0067e80 View commit details
    Browse the repository at this point in the history
  5. Run prettier

    Prvious commits were all made with prettier disabled, because I had
    not yet figured out what syntax error was breaking linting
    
    The commit with the syntax error fixes is easier to read without also
    including all the linting, so I disabled prettier on that commit as
    well
    
    Thus, the linting for the last few commits all in one swell foop
    kb0rg committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    abc8746 View commit details
    Browse the repository at this point in the history
  6. Add a note about pagination

    As a warning to future us, if we scale to having more than 30 zoom
    user accounts
    kb0rg committed Nov 11, 2019
    Configuration menu
    Copy the full SHA
    771463a View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2019

  1. Add user facing messaging if basic acct used

    Note that there is a time limit, and offer workarounds
    
    Inform them instead of annoying them... hopefully
    kb0rg committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    18cfc33 View commit details
    Browse the repository at this point in the history
  2. Remove obsolete accountForEmail

    This is replaced by accountFromUser
    Also make Account type param mandatory
    kb0rg committed Nov 12, 2019
    Configuration menu
    Copy the full SHA
    0ff90d3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    602f59d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2270c12 View commit details
    Browse the repository at this point in the history