Skip to content

Commit

Permalink
Make workflow run workflow in source repo context to prevent secrets …
Browse files Browse the repository at this point in the history
…exposure. Remove file upload since it no longer has access to secrets
  • Loading branch information
bj00rn committed Jun 17, 2024
1 parent 03ba430 commit bb195f4
Showing 1 changed file with 1 addition and 15 deletions.
16 changes: 1 addition & 15 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
on:
pull_request_target: # Use pull_request_target
pull_request:
branches: [master, beta, release]

jobs:
Expand All @@ -22,17 +22,3 @@ jobs:
run: yarn ui-test
- name: Post-processing
run: ./scripts/prepareVideo.sh
- uses: hkusu/s3-upload-action@v2
id: upload # specify some ID for use in subsequent steps
with:
aws-access-key-id: ${{ vars.AWS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
aws-region: 'eu-central-1'
aws-bucket: ${{ vars.AWS_BUCKET }}
file-path: './ui-test.gif'
content-type: image/gif
output-file-url: 'true'
- name: Show URL
run: echo '${{ steps.upload.outputs.file-url }}'
id: artifact-upload-step
- run: echo '<picture><img src="${{ steps.upload.outputs.file-url }}"></picture>' >> $GITHUB_STEP_SUMMARY

0 comments on commit bb195f4

Please sign in to comment.