Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement a way to validate class prop/methods when set/call #3029

Merged
merged 12 commits into from
Jul 3, 2024
Merged

implement a way to validate class prop/methods when set/call #3029

merged 12 commits into from
Jul 3, 2024

Conversation

MohamedElmdary
Copy link
Member

@MohamedElmdary MohamedElmdary commented Jun 25, 2024 •
edited by zaelgohary
Loading

Description

implement a way to validate class prop/methods when set/call

Changes

  • feat: Add a class decrator with options to validate any needed prop/method
  • feat: Use Validate class decrator in ComputeCapacity class to throw error when needed
  • chore: Remove skip from tests and run them using SKIP_PROPS_VALIDATION=true env var

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Mahmoud-Emad
Mahmoud-Emad requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Rabe3 :)

packages/grid_client/src/helpers/validator.ts Outdated Show resolved Hide resolved
@MohamedElmdary
- chore: Rename decrator to ValidateMembers instead of Validate
16b9cda 
- fix: Assign prop value before validate
@MohamedElmdary
Merge branch 'development_2.6_implement_class_validation' of github.c…
aa8899f 
…om:threefoldtech/tfgrid-sdk-ts into development_2.6_implement_class_validation
@zaelgohary zaelgohary mentioned this pull request Jun 26, 2024
Open
Base automatically changed from development_2.6 to development July 2, 2024 12:42
@MohamedElmdary MohamedElmdary merged commit b45604f into development Jul 3, 2024
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_2.6_implement_class_validation branch July 3, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453 mohamedamer453 is a code owner

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees

@MohamedElmdary MohamedElmdary

@zaelgohary zaelgohary

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MohamedElmdary @AhmedHanafy725 @Mahmoud-Emad @zaelgohary