Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement a way to validate class prop/methods when set/call #3029

Merged
merged 12 commits into from
Jul 3, 2024
Merged

implement a way to validate class prop/methods when set/call #3029

merged 12 commits into from
Jul 3, 2024

Commits on Jun 25, 2024

  1. feat: Add a class decrator with options to validate any needed prop/m… 

    …ethod
    @MohamedElmdary
    MohamedElmdary committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f245e0a View commit details
    Browse the repository at this point in the history

  2. feat: Use Validate class decrator in ComputeCapacity class to throw e… 

    …rror when needed
    @MohamedElmdary
    MohamedElmdary committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    beda2d1 View commit details
    Browse the repository at this point in the history

  3. chore: Remove skip from tests and run them using SKIP_PROPS_VALIDATIO… 

    …N=true env var
    @MohamedElmdary
    MohamedElmdary committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    02191e4 View commit details
    Browse the repository at this point in the history

  4. fix: Bind to 'this'(aka. current instance) instead of ctor.prototype

    @MohamedElmdary
    MohamedElmdary committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e18e0b4 View commit details
    Browse the repository at this point in the history

  5. fix: split args in super call

    @MohamedElmdary
    MohamedElmdary committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    239de12 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Update grid client workflow to include skip props env

    @zaelgohary
    zaelgohary committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f031ab1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'development_2.6_implement_class_validation' of https://… 

    …github.com/threefoldtech/tfgrid-sdk-ts into development_2.6_implement_class_validation
    @zaelgohary
    zaelgohary committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7abd899 View commit details
    Browse the repository at this point in the history

  3. - chore: Rename decrator to ValidateMembers instead of Validate 

    - fix: Assign prop value before validate
    @MohamedElmdary
    MohamedElmdary committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    16b9cda View commit details
    Browse the repository at this point in the history

  4. Merge branch 'development_2.6_implement_class_validation' of github.c… 

    …om:threefoldtech/tfgrid-sdk-ts into development_2.6_implement_class_validation
    @MohamedElmdary
    MohamedElmdary committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    aa8899f View commit details
    Browse the repository at this point in the history

  5. chore: Add some jsdocs for validatemembers decrator

    @MohamedElmdary
    MohamedElmdary committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    497b586 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'development_2.6' into development_2.6_implement_class_v… 

    …alidation
    @MohamedElmdary
    MohamedElmdary committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    d7f02ef View commit details
    Browse the repository at this point in the history

  2. - chore: Remove env variable while 'SKIP_PROPS_VALIDATION' while test 

    - feat: Add throw expectation while setting cpu/memory in ComputeCapacity
    @MohamedElmdary
    MohamedElmdary committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    40e824d View commit details
    Browse the repository at this point in the history