Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe current maintenance posture #421

Merged
merged 9 commits into from
Apr 12, 2022
Merged

Describe current maintenance posture #421

Changes from 8 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ea239f5
add non pursuing section
Mar 23, 2022
52141e2
retool wordage
Mar 23, 2022
c5a3776
add Jenny's edits
sbearrows Mar 23, 2022
6c06209
move section back down
Mar 23, 2022
4472191
make it a list
Mar 23, 2022
f59123c
change list
Mar 24, 2022
f28cfd7
change to tidyverse org
Apr 1, 2022
d855b04
add more issues to list
Apr 1, 2022
ace973e
add a readr issue
Apr 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion MAINTENANCE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ You would still then have to parse the data afterwards, it is possible there
are approaches that could make this faster than the current implementations as
well.

## Alternative handling of files without trailing newlines
### Alternative handling of files without trailing newlines
sbearrows marked this conversation as resolved.
Show resolved Hide resolved

There is a Stack overflow thread which suggests that if you mmap a file beyond the size the mmap is guaranteed to pad the remainder with 0's.
If this is true we could always do this and in that way handle the case when a
Expand All @@ -89,6 +89,15 @@ strcspn requires the data must end with a NUL, so if we cannot guarantee that th

https://github.com/r-lib/vroom/issues/357 tracks this issue

## Ideas we are not pursuing

The following projects have merit, but would require more maintainer bandwidth than is currently available.
It is helpful to us to (a) record them explicitly for some possible future and (b) get them out of our open issues.

* https://github.com/tidyverse/vroom/issues/186
* https://github.com/tidyverse/vroom/issues/151
* https://github.com/tidyverse/vroom/issues/250

sbearrows marked this conversation as resolved.
Show resolved Hide resolved
## External "standards"

https://datatracker.ietf.org/doc/html/rfc4180