Fix URL query escape for RegionStatsByStartEndKey

Signed-off-by: JmPotato <[email protected]>
tikv · Nov 15, 2023 · 5d35dec · 5d35dec
1 parent 272d561
commit 5d35dec
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/client/http/api.go b/client/http/api.go
@@ -79,7 +79,10 @@ func RegionByKey(key []byte) string {
 // RegionsByKey returns the path of PD HTTP API to scan regions with given start key, end key and limit parameters.
 func RegionsByKey(startKey, endKey []byte, limit int) string {
 	return fmt.Sprintf("%s?start_key=%s&end_key=%s&limit=%d",
-		regionsByKey, url.QueryEscape(string(startKey)), url.QueryEscape(string(endKey)), limit)
+		regionsByKey,
+		url.QueryEscape(string(startKey)),
+		url.QueryEscape(string(endKey)),
+		limit)
 }
 
 // RegionsByStoreID returns the path of PD HTTP API to get regions by store ID.
@@ -88,8 +91,11 @@ func RegionsByStoreID(storeID uint64) string {
 }
 
 // RegionStatsByStartEndKey returns the path of PD HTTP API to get region stats by start key and end key.
-func RegionStatsByStartEndKey(startKey, endKey string) string {
-	return fmt.Sprintf("%s?start_key=%s&end_key=%s", StatsRegion, startKey, endKey)
+func RegionStatsByStartEndKey(startKey, endKey []byte) string {
+	return fmt.Sprintf("%s?start_key=%s&end_key=%s",
+		StatsRegion,
+		url.QueryEscape(string(startKey)),
+		url.QueryEscape(string(endKey)))
 }
 
 // StoreByID returns the store API with store ID parameter.

diff --git a/client/http/client.go b/client/http/client.go
@@ -305,7 +305,7 @@ func (c *client) GetRegionStatusByKey(ctx context.Context, startKey, endKey []by
 	var regionStats RegionStats
 	err := c.requestWithRetry(
 		ctx, "GetRegionStatusByKey",
-		RegionStatsByStartEndKey(string(startKey), string(endKey)), http.MethodGet,
+		RegionStatsByStartEndKey(startKey, endKey), http.MethodGet,
 		&regionStats,
 	)
 	if err != nil {