Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it maybe failed to offline store when it is preparing #8997

Open
lhy1024 opened this issue Jan 14, 2025 · 1 comment
Open

it maybe failed to offline store when it is preparing #8997

lhy1024 opened this issue Jan 14, 2025 · 1 comment
Labels
type/bug The issue is confirmed as a bug.

Comments

@lhy1024
Copy link
Contributor

lhy1024 commented Jan 14, 2025

Bug Report

What did you do?

offline store when it is preparing in test

What did you expect to see?

store is offline

What did you see instead?

2025-01-14T08:43:50.8117961Z [2025/01/14 08:43:27.876 +00:00] [WARN] [cluster.go:1474] ["store has been offline"] [store-id=1] [store-address=tikv1] [physically-destroyed=false]
2025-01-14T08:43:50.8119445Z [2025/01/14 08:43:28.483 +00:00] [WARN] [tso.go:297] ["clock offset"] [] [jet-lag=466.470615ms] [prev-physical=2025/01/14 08:43:28.017 +00:00] [now=2025/01/14 08:43:28.483 +00:00] [update-physical-interval=50ms]
2025-01-14T08:43:50.8120896Z [2025/01/14 08:43:28.620 +00:00] [INFO] [cluster.go:1678] ["store has changed to serving"] [store-id=1] [store-address=tikv1]
2025-01-14T08:43:50.8121788Z [2025/01/14 08:43:29.101 +00:00] [INFO] [cluster.go:2407] ["store limit changed"] [store-id=1] [type=remove-peer] [rate-per-min=100000000]
2025-01-14T08:43:50.8122932Z [2025/01/14 08:43:29.341 +00:00] [INFO] [audit.go:128] ["audit log"] [service-info="{ServiceLabel:DeleteStore, Method:HTTP/1.1/DELETE:/pd/api/v1/store/2, CallerID:anonymous, IP:127.0.0.1, Port:52560, StartTime:2025-01-14 08:43:29 +0000 UTC, URLParam:{}, BodyParam:}"]
2025-01-14T08:43:50.8124241Z [2025/01/14 08:43:29.342 +00:00] [WARN] [cluster.go:1474] ["store has been offline"] [store-id=2] [store-address=tikv2] [physically-destroyed=false]
2025-01-14T08:43:50.8125240Z [2025/01/14 08:43:29.362 +00:00] [WARN] [tso.go:297] ["clock offset"] [] [jet-lag=234.966935ms] [prev-physical=2025/01/14 08:43:29.127 +00:00] [now=2025/01/14 08:43:29.361 +00:00] [update-physical-interval=50ms]

store 1 is changed to serving after offline

What version of PD are you using (pd-server -V)?

@lhy1024 lhy1024 added the type/bug The issue is confirmed as a bug. label Jan 14, 2025
@lhy1024
Copy link
Contributor Author

lhy1024 commented Jan 14, 2025

We check store state in runNodeStateCheckJob and try to set store from preparing to serving.
If the code run in below order

t runNodeStateCheckJob RemoveStore
t1
if store.IsPreparing() {
t2
if err := c.setStore(newStore); err != nil {
t3
err := c.setStore(newStore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

1 participant