Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: make TestRemovingProgress stable #8998

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Jan 14, 2025

What problem does this PR solve?

Issue Number: Close #8992

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed labels Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.27%. Comparing base (dd8df1a) to head (c9e7db7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8998      +/-   ##
==========================================
+ Coverage   76.24%   76.27%   +0.03%     
==========================================
  Files         465      465              
  Lines       70534    70534              
==========================================
+ Hits        53777    53801      +24     
+ Misses      13406    13377      -29     
- Partials     3351     3356       +5     
Flag Coverage Δ
unittests 76.27% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lhy1024 lhy1024 requested review from okJiang and rleungx January 15, 2025 03:17
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 15, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 15, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 15, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 15, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-15 03:20:16.697382178 +0000 UTC m=+88688.152428315: ☑️ agreed by rleungx.
  • 2025-01-15 03:55:58.827431678 +0000 UTC m=+90830.282477827: ☑️ agreed by okJiang.

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jan 16, 2025

/retest

@lhy1024
Copy link
Contributor Author

lhy1024 commented Jan 16, 2025

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 2ae49cb into tikv:master Jan 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestRemovingProgress is unstable
3 participants