Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Add APIs for RawKV GC #5138

Closed

Conversation

AmoebaProtozoa
Copy link
Contributor

Signed-off-by: AmoebaProtozoa [email protected]

What problem does this PR solve?

Add APIs for RawKV GC (client part of #4866).
Issue Number: ref #4865
RFC: tikv/rfcs#90

What is changed and how does it work?

Add APIs for RawKV GC.

Check List

Tests

  • Manual tests with server

Code changes

Side effects
No

Release note

Add APIs for RawKV GC.

Signed-off-by: AmoebaProtozoa <[email protected]>
Signed-off-by: AmoebaProtozoa <[email protected]>
Signed-off-by: AmoebaProtozoa <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
Signed-off-by: David <[email protected]>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 9, 2022
@ti-chi-bot ti-chi-bot requested review from nolouch and Yisaer June 9, 2022 07:59
@AmoebaProtozoa AmoebaProtozoa changed the title server: Add APIs for RawKV GC [WIP] server: Add APIs for RawKV GC Jun 9, 2022
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #5138 (90c9360) into master (b100049) will decrease coverage by 0.21%.
The diff coverage is 50.47%.

@@            Coverage Diff             @@
##           master    #5138      +/-   ##
==========================================
- Coverage   75.65%   75.44%   -0.22%     
==========================================
  Files         310      312       +2     
  Lines       30675    30959     +284     
==========================================
+ Hits        23208    23357     +149     
- Misses       5463     5579     +116     
- Partials     2004     2023      +19     
Flag Coverage Δ
unittests 75.44% <50.47%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/gc_client.go 0.00% <0.00%> (ø)
client/metrics.go 100.00% <ø> (ø)
tests/cluster.go 79.59% <25.00%> (-0.75%) ⬇️
server/storage/kv/etcd_kv.go 69.56% <46.42%> (-10.15%) ⬇️
client/client.go 68.54% <60.00%> (+0.02%) ⬆️
server/storage/endpoint/gc_key_space.go 70.00% <71.42%> (+3.33%) ⬆️
server/gc_service.go 74.02% <74.02%> (ø)
pkg/testutil/testutil.go 93.93% <100.00%> (+0.60%) ⬆️
server/server.go 74.30% <100.00%> (-0.77%) ⬇️
server/storage/endpoint/key_path.go 100.00% <100.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b100049...90c9360. Read the comment docs.

@AmoebaProtozoa AmoebaProtozoa changed the title [WIP] server: Add APIs for RawKV GC server: Add APIs for RawKV GC Jun 10, 2022
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 10, 2022
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2022
Signed-off-by: David <[email protected]>
@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 22, 2022
@ti-chi-bot
Copy link
Member

@AmoebaProtozoa: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants