-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/operators: pause all checkers to make test stable #8166
Conversation
Signed-off-by: husharp <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8166 +/- ##
==========================================
+ Coverage 77.34% 77.37% +0.02%
==========================================
Files 471 471
Lines 61367 61353 -14
==========================================
+ Hits 47464 47470 +6
+ Misses 10331 10307 -24
- Partials 3572 3576 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
/merge |
@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 86e3033
|
@HuSharp: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: Ref #7969
What is changed and how does it work?
pd/tests/server/api/operator_test.go
Lines 654 to 657 in 86e3033
For example, when operators are to be tested in
TestRemoveOperators
will meetreplace the old operators
which is triggered bylabeler-split-region
and make test failed inpd/tests/server/api/operator_test.go
Lines 658 to 659 in 86e3033
Check List
Tests
Release note