scheduler: skip evict-leader-scheduler when setting schedule deny label

.gitignore

@@ -26,3 +26,4 @@ coverage
 *.txt
 go.work*
 embedded_assets_handler.go
+*.log

client/http/interface.go

@@ -767,6 +767,7 @@ func (c *client) CreateScheduler(ctx context.Context, name string, storeID uint6
 		WithBody(inputJSON))
 }
 
+// DeleteScheduler deletes a scheduler from PD cluster.
 func (c *client) DeleteScheduler(ctx context.Context, name string) error {
 	return c.request(ctx, newRequestInfo().
 		WithName(deleteSchedulerName).

tests/integrations/realcluster/deploy.sh

@@ -19,13 +19,13 @@ if [ ! -d "bin" ] || [ ! -e "bin/tikv-server" ] && [ ! -e "bin/tidb-server" ] &&
 	color-green "downloading binaries..."
 	color-green "this may take a few minutes, you can also download them manually and put them in the bin directory."
 	make pd-server WITH_RACE=1
-	$TIUP_BIN_DIR playground nightly --kv 3 --tiflash 1 --db 1 --pd 3 --without-monitor --tag pd_test \
+	$TIUP_BIN_DIR playground nightly --kv 3 --tiflash 1 --db 1 --pd 3 --without-monitor --tag pd_real_cluster_test \
 		--pd.binpath ./bin/pd-server \
 		> $CUR_PATH/playground.log 2>&1 &
 else
 	color-green "using existing binaries..."
 	$TIUP_BIN_DIR playground nightly --kv 3 --tiflash 1 --db 1 --pd 3 --without-monitor \
-		--pd.binpath ./bin/pd-server --kv.binpath ./bin/tikv-server --db.binpath ./bin/tidb-server --tiflash.binpath ./bin/tiflash --tag pd_test \
+		--pd.binpath ./bin/pd-server --kv.binpath ./bin/tikv-server --db.binpath ./bin/tidb-server --tiflash.binpath ./bin/tiflash --tag pd_real_cluster_test \
 		> $CUR_PATH/playground.log 2>&1 &
 fi
 

tests/integrations/realcluster/scheduler_test.go

@@ -1,4 +1,4 @@
-// Copyright 2023 TiKV Authors
+// Copyright 2024 TiKV Authors
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
@@ -21,6 +21,7 @@ import (
 	"testing"
 	"time"
 
+	"github.com/pingcap/log"
 	"github.com/stretchr/testify/require"
 	pd "github.com/tikv/pd/client/http"
 	"github.com/tikv/pd/client/testutil"
@@ -79,7 +80,7 @@ func TestTransferLeader(t *testing.T) {
 	re.Len(res, oldSchedulersLen)
 }
 
-func TestRegionLabel_DenyScheduler(t *testing.T) {
+func TestRegionLabelDenyScheduler(t *testing.T) {
 	re := require.New(t)
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
@@ -141,11 +142,12 @@ func TestRegionLabel_DenyScheduler(t *testing.T) {
 		}
 	}
 	// check shuffle leader scheduler of region1 has been disabled
-	for i := 0; i < 10; i++ {
+	for i := 0; i < 20; i++ {
 		regions, err := pdHTTPCli.GetRegions(ctx)
 		re.NoError(err)
 		for _, region := range regions.Regions {
 			if region.ID == region1.ID {
+				log.Info("hit region 1")
 				re.True(region.Leader.StoreID == region1.Leader.StoreID)
 			}
 		}
@@ -156,18 +158,23 @@ func TestRegionLabel_DenyScheduler(t *testing.T) {
 		regions, err := pdHTTPCli.GetRegions(ctx)
 		re.NoError(err)
 		for _, region := range regions.Regions {
+			if region.ID == region2.ID {
+				log.Info("hit region 2")
+			}
 			if region.ID == region2.ID && region.Leader.StoreID != region2.Leader.StoreID {
 				return true
 			}
 		}
 		return false
 	})
 
-	oldRegions, err := pdHTTPCli.GetRegionsByStoreID(ctx, uint64(region1.Leader.StoreID))
+	oldRegions, err := pdHTTPCli.GetRegions(ctx)
 	re.NoError(err)
 	oldRegionMap := make(map[int64]bool, len(oldRegions.Regions))
 	for _, region := range oldRegions.Regions {
-		oldRegionMap[region.ID] = true
+		if region.Leader.ID == region1.Leader.ID {
+			oldRegionMap[region.ID] = true
+		}
 	}
 	// enable evict leader scheduler, and check it works
 	re.NoError(pdHTTPCli.CreateScheduler(ctx, schedulers.EvictLeaderName, uint64(region1.Leader.StoreID)))