Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: genericize the batch controller #8793

Merged
merged 4 commits into from
Nov 11, 2024
+366 −257

Address the comment

ca06db6
Select commit
Loading
Failed to load commit list.
Merged

client: genericize the batch controller #8793

Address the comment
ca06db6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 11, 2024 in 0s

70.00% of diff hit (target 75.64%)

View this Pull Request on Codecov

70.00% of diff hit (target 75.64%)

Annotations

Check warning on line 85 in client/batch_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/batch_controller.go#L81-L85 

Added lines #L81 - L85 were not covered by tests

Check warning on line 149 in client/batch_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/batch_controller.go#L139-L149 

Added lines #L139 - L149 were not covered by tests

Check warning on line 164 in client/batch_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/batch_controller.go#L157-L164 

Added lines #L157 - L164 were not covered by tests

Check warning on line 167 in client/batch_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/batch_controller.go#L167 

Added line #L167 was not covered by tests

Check warning on line 181 in client/batch_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/batch_controller.go#L172-L181 

Added lines #L172 - L181 were not covered by tests

Check warning on line 194 in client/batch_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/batch_controller.go#L186-L194 

Added lines #L186 - L194 were not covered by tests

Check warning on line 198 in client/batch_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/batch_controller.go#L198 

Added line #L198 was not covered by tests

Check warning on line 339 in client/tso_dispatcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/tso_dispatcher.go#L339 

Added line #L339 was not covered by tests

Check warning on line 387 in client/tso_dispatcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/tso_dispatcher.go#L387 

Added line #L387 was not covered by tests

Check warning on line 392 in client/tso_dispatcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/tso_dispatcher.go#L392 

Added line #L392 was not covered by tests

Check warning on line 403 in client/tso_dispatcher.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

client/tso_dispatcher.go#L403 

Added line #L403 was not covered by tests
View more details on Codecov