Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update kvproto #8816

Merged
merged 2 commits into from
Nov 22, 2024
Merged

*: update kvproto #8816

merged 2 commits into from
Nov 22, 2024

Conversation

overvenus
Copy link
Member

@overvenus overvenus commented Nov 15, 2024

What problem does this PR solve?

Issue Number: ref #4399, ref pingcap/tidb#57338

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test
    Manually run a TiDB cluster, PD works fine.

Release note

None.

Signed-off-by: Neil Shen <[email protected]>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.25%. Comparing base (76e3b43) to head (d1caea3).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8816   +/-   ##
=======================================
  Coverage   75.24%   75.25%           
=======================================
  Files         456      458    +2     
  Lines       71608    71694   +86     
=======================================
+ Hits        53884    53954   +70     
- Misses      14295    14306   +11     
- Partials     3429     3434    +5     
Flag Coverage Δ
unittests 75.25% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@overvenus overvenus changed the title *: update kvproto [WIP] *: update kvproto Nov 15, 2024
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024
@overvenus overvenus changed the title [WIP] *: update kvproto *: update kvproto Nov 18, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2024
@overvenus
Copy link
Member Author

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 19, 2024
@nolouch nolouch added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 19, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nolouch, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-19 03:43:48.168956148 +0000 UTC m=+932590.359825145: ☑️ agreed by nolouch.
  • 2024-11-21 04:05:31.228422139 +0000 UTC m=+90918.848076656: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 22, 2024
@overvenus
Copy link
Member Author

/test pull-integration-realcluster-test

@ti-chi-bot ti-chi-bot bot merged commit 2917d45 into master Nov 22, 2024
26 checks passed
@rleungx rleungx deleted the update-kvproto branch November 22, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants