-
Notifications
You must be signed in to change notification settings - Fork 725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: reset prepare checker once the cache is reset #8860
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8860 +/- ##
==========================================
+ Coverage 75.86% 76.16% +0.29%
==========================================
Files 460 458 -2
Lines 70637 70255 -382
==========================================
- Hits 53591 53511 -80
+ Misses 13673 13384 -289
+ Partials 3373 3360 -13
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we need a unit test for it?
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
e3fea90
to
9101749
Compare
Signed-off-by: Ryan Leung <rleungx@gmail.com>
9101749
to
be95f0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, do we need pick it to 8.5?
} | ||
|
||
// NewController create a new Controller. | ||
func NewController(ctx context.Context, cluster sche.CheckerCluster, conf config.CheckerConfigProvider, ruleManager *placement.RuleManager, labeler *labeler.RegionLabeler, opController *operator.Controller) *Controller { | ||
func NewController(ctx context.Context, cluster sche.CheckerCluster, conf config.CheckerConfigProvider, ruleManager *placement.RuleManager, labeler *labeler.RegionLabeler, opController *operator.Controller, prepareChecker *sche.PrepareChecker) *Controller { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, this function has too many parameters. Do we have any good way to solve it?
pkg/schedule/coordinator.go
Outdated
if c.ShouldRun(collectWaitTime...) { | ||
log.Info("coordinator has finished cluster information preparation") | ||
break | ||
} | ||
select { | ||
case <-ticker.C: | ||
case <-c.ctx.Done(): | ||
log.Info("coordinator stops running") | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the similar log?
8d9a18e
to
c3f0411
Compare
c3f0411
to
ad5fe05
Compare
/retest |
9c2b83a
to
a639570
Compare
/retest |
/retest |
What problem does this PR solve?
Issue Number: Close #8634, might fix #8689
What is changed and how does it work?
Check List
Tests
Release note