Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove api mode concept #8952

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

*: remove api mode concept #8952

wants to merge 4 commits into from

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Dec 27, 2024

What problem does this PR solve?

Issue Number: ref #8477

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 27, 2024
@rleungx rleungx force-pushed the rename-api branch 2 times, most recently from cb81d98 to 806f172 Compare December 27, 2024 05:39
@rleungx rleungx force-pushed the rename-api branch 3 times, most recently from d0055a0 to 3c8d130 Compare December 27, 2024 05:45
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx requested review from lhy1024 and okJiang and removed request for lhy1024 December 30, 2024 10:03
Signed-off-by: Ryan Leung <[email protected]>
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

Attention: Patch coverage is 81.63265% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.28%. Comparing base (4d8009d) to head (1541b55).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8952   +/-   ##
=======================================
  Coverage   76.28%   76.28%           
=======================================
  Files         463      465    +2     
  Lines       70474    70537   +63     
=======================================
+ Hits        53760    53810   +50     
- Misses      13368    13372    +4     
- Partials     3346     3355    +9     
Flag Coverage Δ
unittests 76.28% <81.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: okJiang
Once this PR has been reviewed and has the lgtm label, please ask for approval from rleungx and additionally assign benmeadowcroft for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-31 08:59:15.259886632 +0000 UTC m=+427290.615891172: ☑️ agreed by okJiang.

Signed-off-by: Ryan Leung <[email protected]>
@rleungx
Copy link
Member Author

rleungx commented Jan 2, 2025

/retest

Copy link
Contributor

ti-chi-bot bot commented Jan 3, 2025

@rleungx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 1541b55 link true /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants