Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics: support pyroscope for continous profile #8958

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

metrics: support pyroscope for continous profile #8958

wants to merge 3 commits into from
+47 −0

Conversation

bufferflies
Copy link
Contributor

@bufferflies bufferflies commented Dec 30, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #8957

What is changed and how does it work?

Check List

Tests

Code changes

Side effects

  • Possible performance regression

Related changes

Release note

None.

@bufferflies
support pyroscope
55c3422 
Signed-off-by: 童剑 <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. labels Dec 30, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bufferflies, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 30, 2024
@bufferflies
go mod tidy
2a6220a 
Signed-off-by: 童剑 <[email protected]>
@bufferflies bufferflies marked this pull request as ready for review December 30, 2024 07:18
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 30, 2024
@bufferflies bufferflies changed the title support pyroscope metrics: support pyroscope for continous profile Dec 30, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 76.25%. Comparing base (5999d64) to head (3aa96f1).
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8958      +/-   ##
==========================================
+ Coverage   76.22%   76.25%   +0.02%     
==========================================
  Files         464      464              
  Lines       70516    70537      +21     
==========================================
+ Hits        53754    53785      +31     
+ Misses      13407    13400       -7     
+ Partials     3355     3352       -3
Flag Coverage Δ
unittests 76.25% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@bufferflies
format
3aa96f1 
Signed-off-by: 童剑 <[email protected]>
okJiang
okJiang reviewed Jan 2, 2025
View reviewed changes
pkg/utils/metricutil/metricutil.go

// EnablePyroscope enables pyroscope if pyroscope is enabled.
func EnablePyroscope() {
if os.Getenv("PYROSCOPE_SERVER_ADDRESS") != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use config? I think no user will use env to enable this feature🤔

Ref pingcap/tidb#52139 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okJiang okJiang okJiang left review comments

@rleungx rleungx Awaiting requested review from rleungx

@nolouch nolouch Awaiting requested review from nolouch

Assignees
No one assigned
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support pyroscope for golang runtime analyze
2 participants
@bufferflies @okJiang