client: retry checkServiceModeChanged to make tso client work normal #8963
Conversation
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8963 +/- ##
==========================================
+ Coverage 76.22% 76.25% +0.02%
==========================================
Files 464 465 +1
Lines 70516 70548 +32
==========================================
+ Hits 53754 53799 +45
+ Misses 13407 13398 -9
+ Partials 3355 3351 -4
Flags with carried forward coverage won't be shown. Click here to find out more. |
| if err := c.checkServiceModeChanged(); err != nil { | ||
| log.Warn("[pd] failed to check service mode and will check later", zap.Error(err)) | ||
| if err := c.initRetry(c.checkServiceModeChanged); err != nil { | ||
| return err |
There was a problem hiding this comment.
One more thing, we need to handle cancel properly.
There was a problem hiding this comment.
See line 499 and line 495, but I find the caller will also call cancel.
Signed-off-by: okJiang <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JmPotato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
@okJiang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: Close #8962
What is changed and how does it work?
Check List
Tests
Release note