Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: add a new scheduler to balance the regions of the given key range #8988
base: master
Are you sure you want to change the base?
api: add a new scheduler to balance the regions of the given key range #8988
Changes from 5 commits
e693b3e
23ff7d0
1e6d628
d1da5b5
d0cfc2d
d86148f
8bdb7bc
0696ba6
5d5ee0f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 320 in pkg/mcs/scheduling/server/cluster.go
Codecov / codecov/patch
pkg/mcs/scheduling/server/cluster.go#L319-L320
Check warning on line 40 in pkg/schedule/schedulers/balance_key_range.go
Codecov / codecov/patch
pkg/schedule/schedulers/balance_key_range.go#L39-L40
Check warning on line 47 in pkg/schedule/schedulers/balance_key_range.go
Codecov / codecov/patch
pkg/schedule/schedulers/balance_key_range.go#L46-L47
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we use a slice to support multiple key ranges with different roles or engines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to support a multi-key range with same role and engine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can let the API interface like:
Then we can alias the table name by tidb or others to help the user read it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the key range may be some partition of one table, and we can decode this key by ctl.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readability is too poor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
understand, I will add one property to record the table name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Check warning on line 100 in pkg/schedule/schedulers/balance_key_range.go
Codecov / codecov/patch
pkg/schedule/schedulers/balance_key_range.go#L88-L100
Check warning on line 127 in pkg/schedule/schedulers/balance_key_range.go
Codecov / codecov/patch
pkg/schedule/schedulers/balance_key_range.go#L126-L127
Check warning on line 144 in pkg/schedule/schedulers/balance_key_range.go
Codecov / codecov/patch
pkg/schedule/schedulers/balance_key_range.go#L143-L144
Check warning on line 558 in pkg/schedule/schedulers/init.go
Codecov / codecov/patch
pkg/schedule/schedulers/init.go#L557-L558
Check warning on line 565 in pkg/schedule/schedulers/init.go
Codecov / codecov/patch
pkg/schedule/schedulers/init.go#L564-L565
Check warning on line 569 in pkg/schedule/schedulers/init.go
Codecov / codecov/patch
pkg/schedule/schedulers/init.go#L568-L569
Check warning on line 573 in pkg/schedule/schedulers/init.go
Codecov / codecov/patch
pkg/schedule/schedulers/init.go#L572-L573
Check warning on line 577 in pkg/schedule/schedulers/init.go
Codecov / codecov/patch
pkg/schedule/schedulers/init.go#L576-L577
Check warning on line 581 in pkg/schedule/schedulers/init.go
Codecov / codecov/patch
pkg/schedule/schedulers/init.go#L580-L581
Check warning on line 111 in server/api/scheduler.go
Codecov / codecov/patch
server/api/scheduler.go#L109-L111
Check warning on line 115 in server/api/scheduler.go
Codecov / codecov/patch
server/api/scheduler.go#L113-L115
Check warning on line 123 in server/api/scheduler.go
Codecov / codecov/patch
server/api/scheduler.go#L121-L123
Check warning on line 129 in server/api/scheduler.go
Codecov / codecov/patch
server/api/scheduler.go#L127-L129
Check warning on line 134 in server/api/scheduler.go
Codecov / codecov/patch
server/api/scheduler.go#L132-L134