Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: return NodeState in the response of StoreHeartbeat. #8991

Merged
merged 13 commits into from
Jan 17, 2025

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Jan 13, 2025

What problem does this PR solve?

Issue Number: Close #9001, Ref tikv/tikv#18107, Ref tikv/tikv#18042

What is changed and how does it work?

This PR mainly contains the cooperative works on mitigating the performance impacts when scaling.

In this PR, it returns the NodeState in StoreHeartbeatResponse to store nodes,
to notify the corresponsive store to handle it if necessary.

In this PR, it returns the `NodeState` in `StoreHeartbeatResponse` to store nodes,
to notify the corresponsive store to handle it if necessary.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jan 13, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 13, 2025
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator LykxSassinator marked this pull request as ready for review January 16, 2025 03:25
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2025
@LykxSassinator
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2025
Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 16, 2025
@LykxSassinator
Copy link
Contributor Author

/cc @bufferflies @rleungx

@ti-chi-bot ti-chi-bot bot requested review from bufferflies and rleungx January 16, 2025 03:40
Copy link
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But we also need to update go mod before merge PR

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 16, 2025
Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 16, 2025
@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.30%. Comparing base (2ae49cb) to head (d85be4c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8991      +/-   ##
==========================================
- Coverage   76.33%   76.30%   -0.03%     
==========================================
  Files         465      465              
  Lines       70534    70535       +1     
==========================================
- Hits        53839    53825      -14     
- Misses      13356    13366      +10     
- Partials     3339     3344       +5     
Flag Coverage Δ
unittests 76.30% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@bufferflies bufferflies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm, need to merge the kvproto pr first

Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 16, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-16 06:09:07.61438569 +0000 UTC m=+185219.069431839: ☑️ agreed by lhy1024.
  • 2025-01-16 08:15:55.535408329 +0000 UTC m=+192826.990454472: ☑️ agreed by rleungx.

@rleungx
Copy link
Member

rleungx commented Jan 16, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2025
@rleungx
Copy link
Member

rleungx commented Jan 16, 2025

Let's wait for pingcap/kvproto#1291 to be merged first.

Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2025
Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 17, 2025
go.mod Outdated
gotest.tools/gotestsum v1.12.0
)

require (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @rleungx

Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 17, 2025
@ti-chi-bot ti-chi-bot bot requested a review from rleungx January 17, 2025 02:55
@rleungx
Copy link
Member

rleungx commented Jan 17, 2025

/hold cancel

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2025
@ti-chi-bot ti-chi-bot bot merged commit 9805a95 into tikv:master Jan 17, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store_heartbeat: returns NodeState in the response to store.
4 participants