-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: return NodeState in the response of StoreHeartbeat. #8991
Conversation
Signed-off-by: lucasliang <[email protected]>
Skipping CI for Draft Pull Request. |
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
/retest |
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
/cc @bufferflies @rleungx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But we also need to update go mod before merge PR
Signed-off-by: lucasliang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8991 +/- ##
==========================================
- Coverage 76.33% 76.30% -0.03%
==========================================
Files 465 465
Lines 70534 70535 +1
==========================================
- Hits 53839 53825 -14
- Misses 13356 13366 +10
- Partials 3339 3344 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm, need to merge the kvproto pr first
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lhy1024, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Let's wait for pingcap/kvproto#1291 to be merged first. |
Signed-off-by: lucasliang <[email protected]>
Signed-off-by: lucasliang <[email protected]>
go.mod
Outdated
gotest.tools/gotestsum v1.12.0 | ||
) | ||
|
||
require ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can merge it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @rleungx
Signed-off-by: lucasliang <[email protected]>
/hold cancel |
What problem does this PR solve?
Issue Number: Close #9001, Ref tikv/tikv#18107, Ref tikv/tikv#18042
What is changed and how does it work?
This PR mainly contains the cooperative works on
mitigating the performance impacts when scaling
.In this PR, it returns the
NodeState
inStoreHeartbeatResponse
to store nodes,to notify the corresponsive store to handle it if necessary.
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note