Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg: avoid make channel every time #9009

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 17, 2025

What problem does this PR solve?

Issue Number: Close #9004.

What is changed and how does it work?

Only do initialization when there is no channel.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 17, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 17, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 17, 2025
Copy link
Contributor

ti-chi-bot bot commented Jan 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-17 03:32:07.168516012 +0000 UTC m=+262198.623562160: ☑️ agreed by JmPotato.
  • 2025-01-17 04:47:04.540714053 +0000 UTC m=+266695.995760202: ☑️ agreed by lhy1024.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.28%. Comparing base (a99abe3) to head (9b4a8d4).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9009      +/-   ##
==========================================
- Coverage   76.35%   76.28%   -0.07%     
==========================================
  Files         465      465              
  Lines       70536    70512      -24     
==========================================
- Hits        53856    53789      -67     
- Misses      13338    13372      +34     
- Partials     3342     3351       +9     
Flag Coverage Δ
unittests 76.28% <96.66%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit 604b0d6 into tikv:master Jan 17, 2025
25 checks passed
@rleungx rleungx deleted the avoid-create-ch branch January 17, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: TSO proxy will cause pd follower OOM
3 participants