Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cache-size to 0.5.0 #4

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Conversation

kennytm
Copy link

@kennytm kennytm commented Feb 18, 2020

Include the fix to lovesegfault/cache-size#3, allowing sysinfo to be built outside of x86.

@kennytm kennytm force-pushed the kennytm/make-cache-size-test-only branch from be232a4 to d42ff00 Compare February 18, 2020 21:44
@kennytm kennytm changed the title sysinfo: build cache-size on x86 only update cache-size to 0.5.0 Feb 18, 2020
@kennytm
Copy link
Author

kennytm commented Feb 19, 2020

PTAL @lonng @nrc. This is needed to compile TiKV on AArch64.

Copy link

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@nrc nrc merged commit 762badf into tikv Feb 19, 2020
nrc added a commit that referenced this pull request Feb 19, 2020
Port of #4 from @kennytm

Signed-off-by: Nick Cameron <[email protected]>
@nrc
Copy link

nrc commented Feb 19, 2020

I've ported this to the tikv2 branch too.

@kennytm kennytm deleted the kennytm/make-cache-size-test-only branch March 15, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants