Board setup - better pins and modes handling #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setnicka
force-pushed
the
pin_rewrite
branch
3 times, most recently
from
ffd03dc to
baaed16
Compare
* Enhanced autoconfig, which handles capabilities query with mixed modes (fixes issue tino#51) * Pins can be both digital and analog pin (analog pins could be often used as digital pins) * All pins are saved into global board.pins list, each pins exists in one instance and in board.digital/board.analog are references to the same objects
setnicka
force-pushed
the
pin_rewrite
branch
from
baaed16 to
7d55059
Compare
Author
|
There are some failing checks, I will resolve them tomorrow (e.q. update test scenarios because of changes). |
setnicka
force-pushed
the
pin_rewrite
branch
from
bf67666 to
46d2c20
Compare
Author
|
@tino Do you have some time to look at this pull request? Thanks :-) |
Open
After this update digital pin number could be as 0,1,2,3,4,25,26 (as defined in Arduino board definition).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixes issue Capabilities query parsing #51)
used as digital pins)
one instance and in board.digital/board.analog are references to the
same objects