fix: move codemention sentinel to end of comment #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobyhs
reviewed
Oct 8, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
#15 removed the newline after the sentinel in an effort to make mobile notifications better.
It seemed to cause the link to not render in the preamble: #15 (comment)
#16 reverted that piece to get the main branch back to a working state.
How
Looking at other libraries like Graphite, it seems to put the sentinel at the end. No way to know if this is by coincidence, but my guess is that it'll work well.
Test Plan
Run all tests.
Also ran as part of expo#1.
Tested in fork to see if newline was in fact what was causing it, and it was! Verified this PR fixes it.