Skip to content

Comments

Use Sink trait from futures-sink-preview#1244

Merged
carllerche merged 6 commits intotokio-rs:masterfrom
Aaron1011:std-future-codec
Jul 8, 2019
Merged

Use Sink trait from futures-sink-preview#1244
carllerche merged 6 commits intotokio-rs:masterfrom
Aaron1011:std-future-codec

Conversation

@Aaron1011
Copy link
Contributor

This commit updates tokio-futures, tokio-codec, and tokio-sync to use the Sink trait from futures-sink-preview. This allows all of the normal Sink combinators to be used with Tokio

@carllerche
Copy link
Member

Thanks 👍 on the change. I would like to first get a release that includes rust-lang/futures-rs#1706 and rust-lang/futures-rs#1708.

@Aaron1011
Copy link
Contributor Author

@carllerche Updated

Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carllerche carllerche merged commit d4803bc into tokio-rs:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants