Merged
Conversation
Member
|
Thanks. This will be super helpful to help review PRs. Sometimes, I just want to look at what the public API is and the docs can be an easier medium. |
❌ Deploy Preview for tokio-rs failed.
|
hawkw
requested changes
May 18, 2022
Member
hawkw
left a comment
There was a problem hiding this comment.
some suggestions regarding the build configuration. once those are addressed, i think this will look good to me
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Member
Author
|
I'm getting the following error when running |
Member
Author
|
Yup, looks related to rust-lang/rust#96676. |
Darksonn
reviewed
May 18, 2022
hawkw
reviewed
May 18, 2022
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Co-authored-by: Eliza Weisman <eliza@buoyant.io>
Darksonn
reviewed
May 18, 2022
Co-authored-by: Alice Ryhl <alice@ryhl.io>
Co-authored-by: Alice Ryhl <alice@ryhl.io>
Darksonn
approved these changes
May 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch (tries) to setup tracing-style rustdoc previews in PRs; I'm not sure if it works yet. We'll see! I'll update this PR accordingly.