[CR] Rename RandomReader -> NewRandomReader

Because it returns a new random reader, and also that matches the Go naming
conventions. :-)

esti/s3_gateway_test.go

@@ -339,7 +339,7 @@ func TestS3CopyObjectMultipart(t *testing.T) {
 
 	// content
 	r := rand.New(rand.NewSource(17))
-	objContent := testutil.RandomReader(r, largeDataContentLength)
+	objContent := testutil.NewRandomReader(r, largeDataContentLength)
 	srcPath := gatewayTestPrefix + "source-file"
 	destPath := gatewayTestPrefix + "dest-file"
 

pkg/testutil/random.go

@@ -55,7 +55,7 @@ func (r *randomReader) Read(p []byte) (int, error) {
 	return n, nil
 }
 
-// RandomReader returns a reader that will return size bytes from rand.
-func RandomReader(rand *rand.Rand, size int64) io.Reader {
+// NewRandomReader returns a reader that will return size bytes from rand.
+func NewRandomReader(rand *rand.Rand, size int64) io.Reader {
 	return &randomReader{rand: rand, remaining: size}
 }