-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update build.py to pass vllm versions as input parameter and convert version map to dictionary #7500
base: main
Are you sure you want to change the base?
Conversation
Not asking for change on this just bringing up a limitation of python. There is no idea of Again, not rejecting the change, just pointing out the reason for the previous implementation in case this is important for some reason I have not thought of. |
"--triton-container-version", | ||
required=False, | ||
default=DEFAULT_TRITON_VERSION_MAP["triton_container_version"], | ||
help="Provide any released version of project.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the help
message make sense, I don't think we release any dev
versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest a better help message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this parameter indicates current development version of the container, not necessary a released version. Based on this, in my vision, the parameter should be something like triton-development-version
, and help message would be Provide the current development version of the container
. I'm not sure how relevant it would be to provide the past development versions and how much confusion this would introduce to users. Do we really need to expose this parameter? @nv-kmcgill53 and @mc-nv , what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any kind of logic could be added as an expansion for build.py
.
My center of thoughts isn't changed, build.py
requires simplification, any expansion need to be reasonable.
I agree that more moving parts we are adding the more complexity it will bring over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik, this parameter can be used for dev and prod versions of triton container. A better help text for it would be "Provide any development or released version of project"
Is it possible to start a new pipeline for this PR to check if it is goes well? + should we test newly added flags? |
I've tested the changes via this pipeline 18898001 |
What does the PR do?
example - https://github.com/triton-inference-server/vllm_backend/blob/mesharma-ci/ci/build/build_source.sh#L60
Checklist
<commit_type>: <Title>
Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
[Not ready for review, not needed to merge this change] triton-inference-server/vllm_backend#49
Where should the reviewer start?
all changes are contained within build.py script
Test plan:
Build: Trigger CI for new vllm_backend Triton releases vllm_backend#49
All actions are successful and pipeline checks have also passed.
CI Pipeline ID:
17157949
Caveats:
N/A
Background
I was unable to set any specific vllm version while triggering a build and test CI pipeline from vllm_backend repository due to the hard-coding in this build.py script.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A