Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update build.py to pass vllm versions as input parameter and convert version map to dictionary #7500
base: main
Are you sure you want to change the base?
build: update build.py to pass vllm versions as input parameter and convert version map to dictionary #7500
Changes from 42 commits
a1d5ce5
0b9698f
93d54ff
dac4dbd
89289b8
b2f9179
57cd37d
3ce9080
f74b8cb
3750c05
575b1fc
8bd4d7d
e70b17c
e8d5943
1f80660
afa9ad1
4258ae8
4df6b47
1efd283
c9b7f11
9f201f0
07d1f93
eb40600
df14142
8c349ec
d179819
fc008ce
1408822
4ec7274
c5b0e3c
7c958ce
37c9bef
d5219ae
545c2c2
cb9ec87
95e9f16
0070efd
6d531e0
771d115
850f2cf
7e56ec6
ce4de4f
15c8c29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
help
message make sense, I don't think we release anydev
versionsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you suggest a better help message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this parameter indicates current development version of the container, not necessary a released version. Based on this, in my vision, the parameter should be something like
triton-development-version
, and help message would beProvide the current development version of the container
. I'm not sure how relevant it would be to provide the past development versions and how much confusion this would introduce to users. Do we really need to expose this parameter? @nv-kmcgill53 and @mc-nv , what do you think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any kind of logic could be added as an expansion for
build.py
.My center of thoughts isn't changed,
build.py
requires simplification, any expansion need to be reasonable.I agree that more moving parts we are adding the more complexity it will bring over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaik, this parameter can be used for dev and prod versions of triton container. A better help text for it would be "Provide any development or released version of project"