NAS-133904 / 25.10 / Editing the Network Widget saved the values to the other portion of the widget

[bvasilenko]

Testing:

Please see the ticket for replication steps and expected result.

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-133904

[AlexKarpov98]

I was not able to confirm that it fixed the issue.

Can you explain how this change should fix the bug?

That's what I've seen:

Screen.Recording.2025-02-10.at.16.21.21.mov

[bvasilenko]

@AlexKarpov98 Perhaps more details are needed.

I can reproduce the bug at WebUI hosted on the server m50-143a, but using the WebUI built from this PR, the issue does not occur any more, and I see no way how it can occur.

Can you explain how this change should fix the bug?

@AlexKarpov98 The method call sequence was broken. Previously, setValue (line 69) was called before form.valueChanges (line 76) was subscribed. As a result, the form value change was not detected.

[AlexKarpov98]

@bvasilenko I see
Could you attach a video where you test is locally, please? (I want to see how it works for you)

[bvasilenko]

@AlexKarpov98 here's how it works for me:

simplescreenrecorder-2025-02-13_12.52.01.1.mp4

[AlexKarpov98]

It works for me now, issue is resolved magically 👌

Maybe we should do the same for all other widgets?

[AlexKarpov98]

@bvasilenko - yeah, please update in all other places.
I faced the same bug for APPS widget.

I tested using your workaround and it works 👌
I will close the ticket below once it's all merged here.
https://ixsystems.atlassian.net/browse/NAS-134414

[AlexKarpov98]

👍

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.36%. Comparing base (024d866) to head (809b465).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ttings/widget-arbitrary-text-settings.component.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #11524       +/-   ##
===========================================
+ Coverage   60.02%   83.36%   +23.33%     
===========================================
  Files        1655     1655               
  Lines       59255    59255               
  Branches     6409     6409               
===========================================
+ Hits        35568    49397    +13829     
+ Misses      23687     9858    -13829     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.