This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
test: adds test coverage report to @ganache/cli, improve coverage #3735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up as a background process
… (but don't show that in the help, because it's ugly)
…tance files if the process no longer exists.
…tance data file to JSON format.
…mprove detach help
mmand matches (otherwise assume the process has been killed)
…process.cmd matches.
jeffsmale90
force-pushed
the
test/improve_cli_tests
branch
from
944b516
to
9466475
Compare
jeffsmale90
force-pushed
the
test/improve_cli_tests
branch
from
c6e2606
to
784e098
Compare
jeffsmale90
commented
Nov 24, 2022
| @@ -21,6 +21,7 @@ export type StartArgs<TFlavorName extends FlavorName> = | |||
| export type GanacheArgs = | |||
| | (AbstractArgs<"stop"> & { name: string }) | |||
| | AbstractArgs<"list"> | |||
| | AbstractArgs<"none"> | |||
There was a problem hiding this comment.
This is required because Yargs parser no longer terminates the process when argument validation fails (or --help) is passed.
jeffsmale90
force-pushed
the
test/improve_cli_tests
branch
from
2475590
to
3c2a8b9
Compare
…ached. Slow tests, but probably worth it.
… process-name test.
jeffsmale90
force-pushed
the
test/improve_cli_tests
branch
from
57cf37e
to
eea355b
Compare
jeffsmale90
commented
Dec 21, 2022
Comment on lines
+228
to
+231
| if (!isFinite(port) || port < 1 || port > 65535) { | ||
| throw new Error( | ||
| `Port should be >= 0 and < 65536. Received ${port}.` | ||
| ); |
There was a problem hiding this comment.
This will conflict with #4070
MicaiahReid
suggested changes
Jan 5, 2023
src/packages/cli/package.json
Outdated
| @@ -71,7 +73,7 @@ | |||
| "@trufflesuite/ps-list": "0.0.3", | |||
| "@types/node": "17.0.0", | |||
| "chalk": "4.1.0", | |||
| "cli-table": "0.3.11", | |||
| "marked-terminal": "4.1.0" | |||
| "marked-terminal": "4.1.0", | |||
There was a problem hiding this comment.
Was this change on purpose? It seems like the versions are the same and they are now out of alphabetical order.
davidmurdoch
reviewed
Jan 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes some of the components in @ganache/cli more testable, adds coverage report, and improves test coverage to
process-name.tsandargs.ts. The tests forargs.tscover all of the "general" configuration cases, but does not cover the flavor specific arguments.Fixes: #3978