Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

test: adds test coverage report to @ganache/cli, improve coverage #3735

Open
wants to merge 84 commits into
base: develop
Choose a base branch
from
Open

test: adds test coverage report to @ganache/cli, improve coverage #3735

wants to merge 84 commits into from

Commits on Aug 22, 2022

  1. feat: allow users to specify a option, which causes Ganache to start … 

    …up as a background process
    @jeffsmale90
    jeffsmale90 committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    fcc4228 View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2022

  1. Stream stderr from the child to the parent

    @jeffsmale90
    jeffsmale90 committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    7a787f2 View commit details
    Browse the repository at this point in the history

  2. Tidy up of --detach argument parsing

    @jeffsmale90
    jeffsmale90 committed Aug 23, 2022
    Configuration menu
    Copy the full SHA
    301c500 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2022

  1. Improve detach configuration

    @jeffsmale90
    jeffsmale90 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    7dec4c0 View commit details
    Browse the repository at this point in the history

  2. Add tests for parsing detach arguments. Change default value to false… 

    … (but don't show that in the help, because it's ugly)
    @jeffsmale90
    jeffsmale90 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    9ed54db View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Make parent aware of detached instances, and allow stopping them via cli

    @jeffsmale90
    jeffsmale90 committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    20579ae View commit details
    Browse the repository at this point in the history

  2. improve args tests, remove placeholder

    @jeffsmale90
    jeffsmale90 committed Sep 6, 2022
    Configuration menu
    Copy the full SHA
    1da7911 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Implement , and allow different actions to be executed via the CLI

    @jeffsmale90
    jeffsmale90 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    9cc5b59 View commit details
    Browse the repository at this point in the history

  2. Clean up orphaned instance process files. uses a terrible hack to fet… 

    …ch pid list.
    @jeffsmale90
    jeffsmale90 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e5d7e60 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Implement instances command with subcommands. Clean up orphaned ins… 

    …tance files if the process no longer exists.
    @jeffsmale90
    jeffsmale90 committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    295b1a3 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Tidy up args types and parsing

    @jeffsmale90
    jeffsmale90 committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    75ffbb0 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Refactor, add flavor to instance data, and to list output. Change ins… 

    …tance data file to JSON format.
    @jeffsmale90
    jeffsmale90 committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    17732d7 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Fix createFlatChildArgs import in args.test.ts

    @jeffsmale90
    jeffsmale90 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    dea1ddb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feat/detach-mode

    @jeffsmale90
    jeffsmale90 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    07a4b03 View commit details
    Browse the repository at this point in the history

  3. Update package-lock.json files - required for new deps

    @jeffsmale90
    jeffsmale90 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    a74d0a3 View commit details
    Browse the repository at this point in the history

  4. Fix module resolution

    @jeffsmale90
    jeffsmale90 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    1eaea51 View commit details
    Browse the repository at this point in the history

  5. Tidy ups and refactors

    @jeffsmale90
    jeffsmale90 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    cba7589 View commit details
    Browse the repository at this point in the history

  6. Tidy up arg parsing

    @jeffsmale90
    jeffsmale90 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    c39cae6 View commit details
    Browse the repository at this point in the history

  7. Revert package-lock.json files

    @jeffsmale90
    jeffsmale90 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    bc61cb1 View commit details
    Browse the repository at this point in the history

  8. Fix miss-typed action name

    @jeffsmale90
    jeffsmale90 committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    f5650f2 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2022

  1. Remove dependency on ps-list, move data files to Ganache/instances, i… 

    …mprove detach help
    @jeffsmale90
    jeffsmale90 committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    90a2305 View commit details
    Browse the repository at this point in the history

  2. Remove kebab-case names when expanding arguments. Add tests for expan… 

    …dArgs()
    @jeffsmale90
    jeffsmale90 committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    c1e5f43 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Reintroduce ps-list, only list instances where the process co 

    mmand matches (otherwise assume the process has been killed)
    @jeffsmale90
    jeffsmale90 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    757220b View commit details
    Browse the repository at this point in the history

  2. Move createFlatChildArgs() to detach.ts, add version to list, ensure … 

    …process.cmd matches.
    @jeffsmale90
    jeffsmale90 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    c432c35 View commit details
    Browse the repository at this point in the history

  3. Create instances directory recursively, because now it's

    @jeffsmale90
    jeffsmale90 committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    2dec992 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Tidy ups from code review, add section on Detached mode to README.

    @jeffsmale90
    jeffsmale90 committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    773f21a View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2022

  1. Fix incorrect command name in README.md 

    Co-authored-by: Micaiah Reid <[email protected]>
    @jeffsmale90 @MicaiahReid
    jeffsmale90 and MicaiahReid authored Oct 10, 2022
    Configuration menu
    Copy the full SHA
    5fb72d1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into feat/detach-mode

    @jeffsmale90
    jeffsmale90 committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    9bf6064 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2022

  1. Update to use @trufflesuite/ps-list instead of ps-list

    @jeffsmale90
    jeffsmale90 committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    d27e6bc View commit details
    Browse the repository at this point in the history

  2. If no instances are found, using , print a friendly message instead o… 

    …f an empty table
    @jeffsmale90
    jeffsmale90 committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    eafc679 View commit details
    Browse the repository at this point in the history

  3. Revert ganache package version to match develop

    @jeffsmale90
    jeffsmale90 committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    e6ae996 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into feat/detach-mode

    @jeffsmale90
    jeffsmale90 authored Nov 6, 2022
    Configuration menu
    Copy the full SHA
    eb14694 View commit details
    Browse the repository at this point in the history

  5. Bump @trufflesuite/ps-list to include support for node 12

    @jeffsmale90
    jeffsmale90 committed Nov 6, 2022
    Configuration menu
    Copy the full SHA
    876b972 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2022

  1. upgrade @trufflesuite/ps-list to support nodejs < 12.17.0

    @jeffsmale90
    jeffsmale90 committed Nov 7, 2022
    Configuration menu
    Copy the full SHA
    208b149 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Merge branch 'develop' into feat/detach-mode

    @jeffsmale90
    jeffsmale90 authored Nov 9, 2022
    Configuration menu
    Copy the full SHA
    5f4b80d View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2022

  1. Improve wording of --detach description in README.md 

    Co-authored-by: Alex Sherbuck <[email protected]>
    @jeffsmale90 @tenthirtyone
    jeffsmale90 and tenthirtyone authored Nov 13, 2022
    Configuration menu
    Copy the full SHA
    6b61cba View commit details
    Browse the repository at this point in the history

  2. Switched out for (existing dependency via marked-terminal)

    @jeffsmale90
    jeffsmale90 committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    7f36f1f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Move instance list sorting to the consumer that needs the list sorted

    @jeffsmale90
    jeffsmale90 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    ac5aba0 View commit details
    Browse the repository at this point in the history

  2. use detached instance friendly name for instance file (instead of pid)

    @jeffsmale90
    jeffsmale90 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    bfc5cf9 View commit details
    Browse the repository at this point in the history

  3. pass original process.args to startDetachedInstance, calculate expect… 

    …ed process 'cmd' value.
    @jeffsmale90
    jeffsmale90 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    1a52d4c View commit details
    Browse the repository at this point in the history

  4. Fix 'cmd' argument for win32 platform

    @jeffsmale90
    jeffsmale90 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    7a4c256 View commit details
    Browse the repository at this point in the history

  5. Add attribution for duration formatter

    @jeffsmale90
    jeffsmale90 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    67d11fc View commit details
    Browse the repository at this point in the history

  6. Change all detach mode file access to async

    @jeffsmale90
    jeffsmale90 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    683c201 View commit details
    Browse the repository at this point in the history

  7. Adds warning messages if instances removed

    @jeffsmale90
    jeffsmale90 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    60ae164 View commit details
    Browse the repository at this point in the history

  8. Add PID to warning message.

    @jeffsmale90
    jeffsmale90 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    1726ec9 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary detach.test.ts

    @jeffsmale90
    jeffsmale90 committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    0811874 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2022

  1. improvements / refactor as per pr review. 

    - only create instances directory if we are writing
- check whether a name is taken by attempting to write to it
- correctly await removal of instance file when stopping an instance
- correct some wordsmithing
    @jeffsmale90
    jeffsmale90 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    485ff64 View commit details
    Browse the repository at this point in the history

  2. Don't check for existence of the folder each time - just catch the Er… 

    …ror and create it.
    @jeffsmale90
    jeffsmale90 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    1701140 View commit details
    Browse the repository at this point in the history

  3. Accidentally recreated the instance name twice

    @jeffsmale90
    jeffsmale90 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    78a9d0c View commit details
    Browse the repository at this point in the history

  4. Move comment to relevant code

    @jeffsmale90
    jeffsmale90 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    04719a6 View commit details
    Browse the repository at this point in the history

  5. Improvements to detach re PR

    @jeffsmale90
    jeffsmale90 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    3ea9968 View commit details
    Browse the repository at this point in the history

  6. Revert package-lock.json

    @jeffsmale90
    jeffsmale90 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    6a7f3b3 View commit details
    Browse the repository at this point in the history

  7. _Actually_ fix package-lock.json this time

    @jeffsmale90
    jeffsmale90 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    c5c0c31 View commit details
    Browse the repository at this point in the history

  8. Remove nyc dev-dependency from cli/package.json - correct, but irrele… 

    …vant for this PR
    @jeffsmale90
    jeffsmale90 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    bc8d269 View commit details
    Browse the repository at this point in the history

  9. Strip the detach argument correctly before passing arguments to child… 

    … process
    @jeffsmale90
    jeffsmale90 committed Nov 16, 2022
    Configuration menu
    Copy the full SHA
    aa72840 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Add tests for duration formatting - move implementation into detach.ts

    @jeffsmale90
    jeffsmale90 committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    4e8f933 View commit details
    Browse the repository at this point in the history

  2. Rename formatDuration to formatUptime, add --detach example to README… 

    …, handle --detach arg duplication
    @jeffsmale90
    jeffsmale90 committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    6b49cbb View commit details
    Browse the repository at this point in the history

  3. Revert shrinkwrap :/

    @jeffsmale90
    jeffsmale90 committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    0435951 View commit details
    Browse the repository at this point in the history

  4. Pin cli-table dependency to latest release

    @jeffsmale90
    jeffsmale90 committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    959c6dc View commit details
    Browse the repository at this point in the history

  5. Fix failing test

    @jeffsmale90
    jeffsmale90 committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    dfb8b72 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2022

  1. Improve duration formatting, improve readme

    @jeffsmale90
    jeffsmale90 committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    c495cc9 View commit details
    Browse the repository at this point in the history

  2. Annoyingly, args parsing is complicated. Don't try to strip out the d… 

    …etach flags, rather append to the child args, cancelling out all preceeding flags.
    @jeffsmale90
    jeffsmale90 committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    c16cb20 View commit details
    Browse the repository at this point in the history

  3. Instance files now have .json extension. Remove any files / folders f… 

    …rom instances directory that aren't valid json files. Rename 'poppy-seed' to 'poppyseed' because hyphens in the instance name are a pain!
    @jeffsmale90
    jeffsmale90 committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    b272237 View commit details
    Browse the repository at this point in the history

  4. Remove unused import

    @jeffsmale90
    jeffsmale90 committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    c85d022 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Handle errors betterer

    @jeffsmale90
    jeffsmale90 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    359cb6b View commit details
    Browse the repository at this point in the history

  2. Shorten duration formatting, combine host and port, right align PID i… 

    …n instances table. Revert changes to standardise prompts in README
    @jeffsmale90
    jeffsmale90 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    f94442f View commit details
    Browse the repository at this point in the history

  3. RH align Uptime

    @jeffsmale90
    jeffsmale90 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    26af55e View commit details
    Browse the repository at this point in the history

  4. remove unnecessary type assertion, remove datapath suffix

    @jeffsmale90
    jeffsmale90 committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    d717d3f View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2022

  1. Use unlink instead of rm, because node 12

    @jeffsmale90
    jeffsmale90 committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    393702c View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2022

  1. Support ndoe 12 correctly for removal of files and directories

    @jeffsmale90
    jeffsmale90 committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    0507aa4 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2022

  1. Add test coverage, improve test coverage of process-name, and args

    @jeffsmale90
    jeffsmale90 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d09c3d5 View commit details
    Browse the repository at this point in the history

  2. Add integration tests for detach mode - actually starting ganache det… 

    …ached. Slow tests, but probably worth it.
    @jeffsmale90
    jeffsmale90 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    fba36c8 View commit details
    Browse the repository at this point in the history

  3. Increase timeout in startDetachedInstance test, and fix regex test in… 

    … process-name test.
    @jeffsmale90
    jeffsmale90 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    eea355b View commit details
    Browse the repository at this point in the history

  4. Add more tests to cover detach mode

    @jeffsmale90
    jeffsmale90 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f62d0bf View commit details
    Browse the repository at this point in the history

  5. Add explicit test case for the detached ganache instance not starting

    @jeffsmale90
    jeffsmale90 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    4d098ff View commit details
    Browse the repository at this point in the history

  6. Update package-lock.json

    @jeffsmale90
    jeffsmale90 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    3a147c3 View commit details
    Browse the repository at this point in the history

  7. Fix failing test

    @jeffsmale90
    jeffsmale90 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    f11f58f View commit details
    Browse the repository at this point in the history

  8. Fix import so that node 12

    @jeffsmale90
    jeffsmale90 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    d364fab View commit details
    Browse the repository at this point in the history

  9. Increase timeout because slow tests

    @jeffsmale90
    jeffsmale90 committed Nov 29, 2022
    Configuration menu
    Copy the full SHA
    29e6959 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Merge branch 'develop' into test/improve_cli_tests

    @jeffsmale90
    jeffsmale90 committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    dcdcb91 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Ensure that dataPath is created recursively, fix fx/promises import

    @jeffsmale90
    jeffsmale90 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    6571c79 View commit details
    Browse the repository at this point in the history

  2. Remove duplicate dependency declarations from package.json

    @jeffsmale90
    jeffsmale90 committed Dec 21, 2022
    Configuration menu
    Copy the full SHA
    1dc6029 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Merge develop

    @jeffsmale90
    jeffsmale90 committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    4e84063 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Revert change to package.json

    @jeffsmale90
    jeffsmale90 committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    ac57953 View commit details
    Browse the repository at this point in the history