Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test forwarding #787

Merged
merged 4 commits into from
May 23, 2024
Merged

Fix flaky test forwarding #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9d9192e
handle flaky better
TylerJang27 May 23, 2024
1424fe5
fix coalescing
TylerJang27 May 23, 2024
9b90a6e
deliberately break yamllint
TylerJang27 May 23, 2024
84184a0
revert yamllint and streamline repo_tests
TylerJang27 May 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/actions/linter_tests/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ runs:
- name: Install packages and specify defaults
run: |
echo "CLI_PATH=${{ inputs.cli-path }}" >> "$GITHUB_ENV"
if [[ "${{ inputs.linter-version }}" == "Latest" ]]; then
echo "JEST_LINTER_VERSION=Latest" >> "$GITHUB_ENV"
else
# If the linter version is KnownGoodVersions, coalesce to Snapshots
# For flaky analysis.
echo "JEST_LINTER_VERSION=Snapshots" >> "$GITHUB_ENV"
fi

case "$RUNNER_OS" in
Linux)
Expand Down Expand Up @@ -119,7 +126,7 @@ runs:
DEBUG: Driver:nixpkgs-fmt:*, Driver:eslint:*
JEST_SUITE_NAME: Linter Tests
JEST_JUNIT_SUITE_NAME:
"{title} ${{ runner.os }} ${{ inputs.ref-type }} ${{ inputs.linter-version }}"
"{title} ${{ runner.os }} ${{ inputs.ref-type }} ${{ env.JEST_LINTER_VERSION }}"

- name: Upload results
# TODO(Tyler): Add upload on MacOS/Windows once the action supports it.
Expand Down
11 changes: 0 additions & 11 deletions .github/workflows/repo_tests.reusable.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,3 @@ jobs:
JEST_SUITE_NAME: Repo Tests
PLUGINS_TEST_CLI_VERSION: ${{ inputs.cli-version }}
PLUGINS_TEST_CLI_PATH: ${{ inputs.cli-path }}

- name: Upload results
if: "!cancelled()"
uses: trunk-io/analytics-uploader@main
with:
junit-paths: junit.xml
org-slug: trunk-staging-org
token: ${{ secrets.TRUNK_DEBUGGER_TOKEN }}
continue-on-error: true
env:
TRUNK_PUBLIC_API_ADDRESS: https://api.trunk-staging.io
Loading