Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update trunk toolbox config to include additional direct config value - this better supports toolbox logging #902

Merged
merged 18 commits into from
Oct 31, 2024
Merged

Update trunk toolbox config to include additional direct config value - this better supports toolbox logging #902

merged 18 commits into from
Oct 31, 2024

Conversation

EliSchleifer
Copy link
Member

No description provided.

@trunk-io Trunk.io
Copy link

trunk-io bot commented Oct 30, 2024 •
edited
Loading

⏱️ 4h 21m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests ubuntu-latest 1h 21m ⬜ ⬜ 🟩 🟥 🟩 (+3 more)
Linter Tests macOS 1h 15m ⬜ ⬜ 🟩 🟥 🟩 (+3 more)
Tool Tests (ubuntu-latest) 34m 🟩 ⬜ 🟩 🟥 🟩 (+2 more)
Tool Tests (macOS) 32m 🟥 ⬜ 🟩 🟥 🟩 (+2 more)
CodeQL-Build 14m 🟩 🟩 🟩 🟩 🟩 (+4 more)
Action Tests 8m 🟩 ⬜ 🟩 🟥 🟩 (+2 more)
Trunk Check runner [linux] 7m 🟩 ⬜ 🟩 🟥 🟩 (+3 more)
Windows Linter Tests 5m 🟩 ⬜ 🟩 🟩 🟩 (+3 more)
Repo Tests / Plugin Tests 4m 🟩 ⬜ 🟩 🟥 🟩 (+3 more)
Detect changed files 41s 🟩 🟩 🟩 🟩 🟩 (+3 more)
Aggregate Test Results 12s 🟥 🟥 🟩 🟥 🟩 (+3 more)

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@trunk-staging-io Trunk-Staging.io
Copy link

trunk-staging-io bot commented Oct 30, 2024 •
edited
Loading

514 tests were run on 319c01ff. ⏭️ 27 Skipped. View Full Report ↗︎

⏭️ 27 Skipped
  • Testing linter stringslint test CUSTOM
  • Testing formatter swiftformat test basic
  • Testing linter terrascan test aws_db_instance_violation
  • Testing linter terrascan test basic
  • Testing linter brakeman test CUSTOM

... and 22 more

settings

TylerJang27
TylerJang27 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

linters/trunk-toolbox/plugin.yaml Outdated
read_output_from: tmp_file
direct_configs: [toolbox.toml, log4rs.yaml]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be affects_cache

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. not a nit - it's critical

@EliSchleifer EliSchleifer merged commit 21af79c into main Oct 31, 2024
15 checks passed
@EliSchleifer EliSchleifer deleted the eli/toolbox-config branch October 31, 2024 16:51
@trunk-io Trunk.io
Copy link

trunk-io bot commented Nov 1, 2024 •
edited
Loading

0 tests were run on 319c01ff. View Full Report ↗︎

settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerJang27 TylerJang27 TylerJang27 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EliSchleifer @TylerJang27