Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update trunk toolbox config to include additional direct config value - this better supports toolbox logging #902

Merged
merged 18 commits into from
Oct 31, 2024
Merged

Update trunk toolbox config to include additional direct config value - this better supports toolbox logging #902

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
558e151
EliSchleifer Oct 30, 2024
2383875
update config entries to include new log control file
EliSchleifer Oct 30, 2024
26c1d87
test
EliSchleifer Oct 30, 2024
d6b7c54
enable more toolbox rules
EliSchleifer Oct 30, 2024
c81a85e
pre-push override
EliSchleifer Oct 30, 2024
3caadb3
EliSchleifer Oct 30, 2024
3f62b4a
verbse
EliSchleifer Oct 30, 2024
0fb894c
verbse
EliSchleifer Oct 30, 2024
8bf233c
ok
EliSchleifer Oct 30, 2024
8a72284
ok
EliSchleifer Oct 30, 2024
fcc2012
ok
EliSchleifer Oct 30, 2024
6d7cf1f
EliSchleifer Oct 30, 2024
23fbe56
EliSchleifer Oct 30, 2024
2f6c0e6
Update toolbox to 0.5.0
EliSchleifer Oct 30, 2024
17c8e64
remove toolbox file
EliSchleifer Oct 30, 2024
3d34033
Merge branch 'main' into eli/toolbox-config
EliSchleifer Oct 30, 2024
ab630b3
Update plugin.yaml
EliSchleifer Oct 31, 2024
b41c1c4
Update plugin.yaml
EliSchleifer Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .trunk/trunk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ lint:
# enabled linters inherited from github.com/trunk-io/configs plugin
- definition-checker
- [email protected]
- trunk-toolbox@0.4.1
- trunk-toolbox@0.5.0
disabled:
- pylint # pylint diagnostics are too strict
- semgrep
Expand Down
7 changes: 5 additions & 2 deletions linters/trunk-toolbox/plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ version: 0.1

downloads:
- name: trunk-toolbox
version: 0.4.1
version: 0.5.0
downloads:
- os:
linux: unknown-linux-gnu
Expand All @@ -17,7 +17,7 @@ tools:
- name: trunk-toolbox
download: trunk-toolbox
shims: [trunk-toolbox]
known_good_version: 0.4.1
known_good_version: 0.5.0
lint:
definitions:
- name: trunk-toolbox
Expand All @@ -33,7 +33,10 @@ lint:
output: sarif
batch: true
success_codes: [0]
disable_upstream: false
read_output_from: tmp_file
direct_configs: [toolbox.toml, log4rs.yaml]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should be affects_cache

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. not a nit - it's critical

max_concurrency: 1
- name: lint
run: trunk-toolbox --upstream=${upstream-ref} --results=${tmpfile} ${target}
output: sarif
Expand Down
Loading