Update SASL and LDAP pkgconfig names #192
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenLDAP provides the file ldap.pc for its libldap library. This can be verified via libraries/libldap/ldap.pc.in in the repository, https://git.openldap.org/openldap/openldap/-/blob/master/ Our ./configure script checks instead for the name "openldap", which at some point may have been correct, but no longer works. We switch to "ldap" so that we can locate the upstream file. On some platforms (https://bugs.gentoo.org/918512) this will fix a linking error. Thanks to Chris Pritchard for the report and the diagnosis.
Cyrus SASL provides the file libsasl2.pc for its libsasl2 library. This can be verified in its git repository: https://github.com/cyrusimap/cyrus-sasl/blob/master/libsasl2.pc.in Our ./configure script checks instead for the name "cyrussasl", which at some point may have been correct, but no longer works. We switch to "libsasl2" so that we can locate the upstream file. On some platforms (https://bugs.gentoo.org/918512) this will fix a linking error. Thanks to Chris Pritchard for the report and the diagnosis.
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Dec 6, 2023
Add trusteddomainproject/OpenDKIM#192 to the ebuild. Thanks to Chris Pritchard for both the report and the solution. Closes: https://bugs.gentoo.org/918512 Signed-off-by: Michael Orlitzky <[email protected]>
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Mar 4, 2024
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Mar 11, 2024
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Mar 11, 2024
PR trusteddomainproject#171, trusteddomainproject#192, and trusteddomainproject#203 contains changes in configure.ac, however they were not always reflect their changes into configure. So rebuild it here.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
…kgconfig Fix pkgconfig names of Cyrus SASL and OpenLDAP in configure.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
PR trusteddomainproject#171, trusteddomainproject#192, and trusteddomainproject#204 contains changes in configure.ac, however they were not always reflect their changes into configure. So rebuild it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The names of the pkgconfig files we use to look up libsasl2 and libldap are outdated(?). In any case, they're wrong now. The commit messages give pointers to the upstream files. We update the two lines in
configure.acto use the right names.