Assert SMFIF capabilities so that LUA odkim.add_rcpt, odkim.del_rcpt, odkim.del_header and odkim.quarantine actually work #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…INE if FinalPolicyScript is set so that odkim.add_rcpt, odkim.del_rcpt, odkim.del_header and odkim.quarantine work predictably regardless of other configuration parameters
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 9, 2024
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
Fix issue trusteddomainproject#213: Enforces activation of SMFIF_ADDRCPT, SMFIF_DELRCPT, SMFIF_CHGHDRS and SMFIF_QUARANTINE capabilities if FinalPolicyScript is defined in opendkim.conf, so that the LUA final policy script functions odkim.add_rcpt, odkim.del_rcpt, odkim.del_header and odkim.quarantine actually work regardless of other configuration parameters.
futatuki
added a commit
to futatuki/OpenDKIM
that referenced
this pull request
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LUA final policy script functions odkim.add_rcpt, odkim.del_rcpt, odkim.del_header and odkim.quarantine need some Milter capability flags to be set (respectivley: SMFIF_ADDRCPT, SMFIF_DELRCPT, SMFIF_CHGHDRS and SMFIF_QUARANTINE), but these capabilities are not always activated depending on OpenDKIM configuration parameters.
This patch enforces activation of these capabilities if FinalPolicyScript is defined in opendkim.conf, so that related functions actually work regardless of other configuration parameters.