Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WWRift charm mice and regular string cheese #302

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Fix WWRift charm mice and regular string cheese #302

merged 1 commit into from
Apr 24, 2024

Conversation

hymccord
Copy link
Contributor

Closes: #301

@hymccord hymccord marked this pull request as draft April 23, 2024 14:17
@hymccord
Copy link
Contributor Author

hymccord commented Apr 23, 2024 •
edited
Loading

Thanks for pointing out errors! I've been meaning to make the sample output spit out warnings if an existing PCC goes down in mice, which tends to be something to look into!

This one had some super old code and was before I knew about the cheese being able to combined with forward slashes.

Forgot to rebase! Fixing.

@hymccord hymccord force-pushed the more-wwrift-fixes branch from 6c6b3dd to c4acf5c Compare April 23, 2024 22:02
@hymccord
Copy link
Contributor Author

Sampling

Whisker Woods Rift, Low/Low/Low, Brie String, Cherry (New PCC)
  Score: 56.78
  Sample Size: 19404
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Low, Brie String, Gnarled (New PCC)
  Score: 51.75
  Sample Size: 16703
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Low, Brie String, Stagnant (New PCC)
  Score: 54.08
  Sample Size: 17778
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Low, Brie String, - (New PCC)
  Score: 100
  Sample Size: 63346
  Mouse Count: 9

Whisker Woods Rift, Low/Low/Low, Swiss String, Cherry (New PCC)
  Score: 56.78
  Sample Size: 19404
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Low, Swiss String, Gnarled (New PCC)
  Score: 51.75
  Sample Size: 16703
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Low, Swiss String, Stagnant (New PCC)
  Score: 54.08
  Sample Size: 17778
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Low, Swiss String, - (New PCC)
  Score: 100
  Sample Size: 63346
  Mouse Count: 9

Whisker Woods Rift, Low/Low/Low, Magical String, Cherry
  Score: 35.39 -> 36.88
  Sample Size: 9061 -> 10628
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Low/Low, Magical String, Gnarled
  Score: 32.75 -> 34.07
  Sample Size: 7971 -> 9328
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Low/Low, Magical String, Stagnant
  Score: 32.51 -> 33.6
  Sample Size: 7862 -> 9097
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Low/Low, Magical String, -
  Score: 36.88 -> 37.81
  Sample Size: 9281 -> 9651
  Mouse Count: 10 -> 10

Whisker Woods Rift, Low/Low/Medium, Brie String, Cherry (New PCC)
  Score: 11.89
  Sample Size: 1761
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Medium, Brie String, Gnarled (New PCC)
  Score: 12.39
  Sample Size: 1922
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Medium, Brie String, Stagnant (New PCC)
  Score: 29.61
  Sample Size: 8500
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Medium, Brie String, - (New PCC)
  Score: 31.7
  Sample Size: 8449
  Mouse Count: 9

Whisker Woods Rift, Low/Low/Medium, Swiss String, Cherry (New PCC)
  Score: 11.89
  Sample Size: 1761
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Medium, Swiss String, Gnarled (New PCC)
  Score: 12.39
  Sample Size: 1922
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Medium, Swiss String, Stagnant (New PCC)
  Score: 29.61
  Sample Size: 8500
  Mouse Count: 10

Whisker Woods Rift, Low/Low/Medium, Swiss String, - (New PCC)
  Score: 31.7
  Sample Size: 8449
  Mouse Count: 9

Whisker Woods Rift, Low/Low/Medium, Magical String, Cherry
  Score: 7.92 -> 8.11
  Sample Size: 858 -> 955
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Low/Medium, Magical String, Gnarled
  Score: 8.77 -> 9.11
  Sample Size: 1040 -> 1179
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Low/Medium, Magical String, Stagnant
  Score: 17.68 -> 18.24
  Sample Size: 3472 -> 3944
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Low/Medium, Magical String, -
  Score: 7.51 -> 7.61
  Sample Size: 794 -> 816
  Mouse Count: 10 -> 10

Whisker Woods Rift, Low/Low/High, Brie String, Stagnant (New PCC)
  Score: 10.8
  Sample Size: 1289
  Mouse Count: 8

Whisker Woods Rift, Low/Low/High, Brie String, - (New PCC)
  Score: 15.8
  Sample Size: 2381
  Mouse Count: 7

Whisker Woods Rift, Low/Low/High, Swiss String, Stagnant (New PCC)
  Score: 10.8
  Sample Size: 1289
  Mouse Count: 8

Whisker Woods Rift, Low/Low/High, Swiss String, - (New PCC)
  Score: 15.8
  Sample Size: 2381
  Mouse Count: 7

Whisker Woods Rift, Low/Low/High, Magical String, Stagnant
  Score: 6.6 -> 6.96
  Sample Size: 506 -> 613
  Mouse Count: 8 -> 9

Whisker Woods Rift, Low/Medium/Low, Brie String, Cherry (New PCC)
  Score: 13.55
  Sample Size: 2176
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Low, Brie String, Gnarled (New PCC)
  Score: 28.08
  Sample Size: 7905
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Low, Brie String, Stagnant (New PCC)
  Score: 12.02
  Sample Size: 1778
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Low, Brie String, - (New PCC)
  Score: 33.05
  Sample Size: 9411
  Mouse Count: 9

Whisker Woods Rift, Low/Medium/Low, Swiss String, Cherry (New PCC)
  Score: 13.55
  Sample Size: 2176
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Low, Swiss String, Gnarled (New PCC)
  Score: 28.08
  Sample Size: 7905
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Low, Swiss String, Stagnant (New PCC)
  Score: 12.02
  Sample Size: 1778
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Low, Swiss String, - (New PCC)
  Score: 33.05
  Sample Size: 9411
  Mouse Count: 9

Whisker Woods Rift, Low/Medium/Low, Magical String, Cherry
  Score: 9.55 -> 10.02
  Sample Size: 1197 -> 1385
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Medium/Low, Magical String, Gnarled
  Score: 17.93 -> 18.53
  Sample Size: 3604 -> 4105
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Medium/Low, Magical String, Stagnant
  Score: 8.15 -> 8.48
  Sample Size: 915 -> 1046
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Medium/Low, Magical String, -
  Score: 7.73 -> 7.82
  Sample Size: 815 -> 835
  Mouse Count: 10 -> 10

Whisker Woods Rift, Low/Medium/Medium, Brie String, Cherry (New PCC)
  Score: 14.13
  Sample Size: 2035
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Medium, Brie String, Gnarled (New PCC)
  Score: 8.61
  Sample Size: 845
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Medium, Brie String, Stagnant (New PCC)
  Score: 8.57
  Sample Size: 825
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Medium, Brie String, - (New PCC)
  Score: 6.19
  Sample Size: 445
  Mouse Count: 9

Whisker Woods Rift, Low/Medium/Medium, Swiss String, Cherry (New PCC)
  Score: 14.13
  Sample Size: 2035
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Medium, Swiss String, Gnarled (New PCC)
  Score: 8.61
  Sample Size: 845
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Medium, Swiss String, Stagnant (New PCC)
  Score: 8.57
  Sample Size: 825
  Mouse Count: 10

Whisker Woods Rift, Low/Medium/Medium, Swiss String, - (New PCC)
  Score: 6.19
  Sample Size: 445
  Mouse Count: 9

Whisker Woods Rift, Low/Medium/Medium, Magical String, Cherry
  Score: 9.73 -> 10.25
  Sample Size: 1108 -> 1292
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Medium/Medium, Magical String, Gnarled
  Score: 5.6 -> 5.82
  Sample Size: 401 -> 463
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Medium/Medium, Magical String, Stagnant
  Score: 5.22 -> 5.3
  Sample Size: 369 -> 404
  Mouse Count: 10 -> 11

Whisker Woods Rift, Low/Medium/High, Brie String, - (New PCC)
  Score: 3.57
  Sample Size: 130
  Mouse Count: 7

Whisker Woods Rift, Low/Medium/High, Swiss String, - (New PCC)
  Score: 3.57
  Sample Size: 130
  Mouse Count: 7

Whisker Woods Rift, Low/High/Low, Brie String, Gnarled (New PCC)
  Score: 10.02
  Sample Size: 1153
  Mouse Count: 8

Whisker Woods Rift, Low/High/Low, Brie String, - (New PCC)
  Score: 16.39
  Sample Size: 2514
  Mouse Count: 7

Whisker Woods Rift, Low/High/Low, Swiss String, Gnarled (New PCC)
  Score: 10.02
  Sample Size: 1153
  Mouse Count: 8

Whisker Woods Rift, Low/High/Low, Swiss String, - (New PCC)
  Score: 16.39
  Sample Size: 2514
  Mouse Count: 7

Whisker Woods Rift, Low/High/Low, Magical String, Gnarled
  Score: 6.13 -> 6.41
  Sample Size: 489 -> 573
  Mouse Count: 8 -> 9

Whisker Woods Rift, Low/High/Low, Magical String, -
  Score: 6.57 -> 6.61
  Sample Size: 567 -> 571
  Mouse Count: 8 -> 8

Whisker Woods Rift, Low/High/Medium, Brie String, - (New PCC)
  Score: 3.31
  Sample Size: 117
  Mouse Count: 7

Whisker Woods Rift, Low/High/Medium, Swiss String, - (New PCC)
  Score: 3.31
  Sample Size: 117
  Mouse Count: 7

Whisker Woods Rift, Medium/Low/Low, Brie String, Cherry (New PCC)
  Score: 29.89
  Sample Size: 8562
  Mouse Count: 10

Whisker Woods Rift, High/Medium/Medium, Magical String, -
  Score: 8.22 -> 8.33
  Sample Size: 725 -> 742
  Mouse Count: 8 -> 8

Whisker Woods Rift, High/Medium/Medium, Lactrodectus Lancashire, -
  Score: 2.04 -> 2.03
  Sample Size: 346 -> 375
  Mouse Count: 7 -> 7

Whisker Woods Rift, High/Medium/High, Brie String, - (New PCC)
  Score: 6.97
  Sample Size: 404
  Mouse Count: 5

Whisker Woods Rift, High/Medium/High, Swiss String, - (New PCC)
  Score: 6.97
  Sample Size: 404
  Mouse Count: 5

Whisker Woods Rift, High/Medium/High, Magical String, -
  Score: 10.07 -> 10.22
  Sample Size: 949 -> 981
  Mouse Count: 6 -> 6

Whisker Woods Rift, High/Medium/High, Lactrodectus Lancashire, -
  Score: 1.77 -> 1.85
  Sample Size: 236 -> 258
  Mouse Count: 5 -> 5

Whisker Woods Rift, High/High/Medium, Brie String, - (New PCC)
  Score: 6.81
  Sample Size: 380
  Mouse Count: 5

Whisker Woods Rift, High/High/Medium, Swiss String, - (New PCC)
  Score: 6.81
  Sample Size: 380
  Mouse Count: 5

Whisker Woods Rift, High/High/Medium, Magical String, -
  Score: 8.73 -> 8.94
  Sample Size: 815 -> 864
  Mouse Count: 6 -> 6

Whisker Woods Rift, High/High/Medium, Lactrodectus Lancashire, -
  Score: 2.19 -> 2.2
  Sample Size: 415 -> 418
  Mouse Count: 5 -> 5

Whisker Woods Rift, High/High/High, Brie String, - (New PCC)
  Score: 63.15
  Sample Size: 6227
  Mouse Count: 3

Whisker Woods Rift, High/High/High, Swiss String, - (New PCC)
  Score: 63.15
  Sample Size: 6227
  Mouse Count: 3

Whisker Woods Rift, High/High/High, Magical String, -
  Score: 100 -> 100
  Sample Size: 25320 -> 25818
  Mouse Count: 4 -> 4

Whisker Woods Rift, High/High/High, Lactrodectus Lancashire, -
  Score: 100 -> 100
  Sample Size: 78795 -> 79679
  Mouse Count: 1 -> 1

@hymccord hymccord marked this pull request as ready for review April 23, 2024 22:05
tsitu
tsitu approved these changes Apr 24, 2024
View reviewed changes
Copy link
Owner

@tsitu tsitu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NGL, I forgot about the forward slash trick too, it's been years since we've had to use it 😅

LGTM, thanks for the quick fix!

@tsitu tsitu merged commit a7cb82b into tsitu:master Apr 24, 2024
2 checks passed
@tsitu tsitu mentioned this pull request Apr 24, 2024
Open
12 tasks
@hymccord hymccord deleted the more-wwrift-fixes branch April 24, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsitu tsitu tsitu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issues with WWRift pop script update from PR #296
2 participants
@hymccord @tsitu