-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_pbs and test #2749
add_pbs and test #2749
Conversation
add function and test of pbs |
Codecov Report
@@ Coverage Diff @@
## main #2749 +/- ##
===========================================
- Coverage 89.83% 76.53% -13.31%
===========================================
Files 30 30
Lines 28612 28321 -291
Branches 5587 5314 -273
===========================================
- Hits 25704 21675 -4029
- Misses 1654 5331 +3677
- Partials 1254 1315 +61
Flags with carried forward coverage won't be shown. Click here to find out more. see 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Looks good, thanks @atongsa ! Looks like you're missing the changes for the actual module code in this PR though? |
BTW - you can push your code more than once to a PR - there's no need to create a new one. |
ok |
Sorry we've been slow to review this PR @atongsa, it's hard to keep up sometimes. We would like to incorporate this statistic, but it will take some more work. Would you mind leaving the PR open please? |
actually, i am sorry |
Description
add a PBS function to test population local adaptation;
solve the issue #2717;
Fixes #(2717) <- Putting the issue number here will auto-close the issue when this PR is merged
PR Checklist: