Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 32bit CI #2811

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Fix 32bit CI #2811

merged 1 commit into from
Aug 4, 2023

Conversation

benjeffery
Copy link
Member

Latest cython breaks compilation of h5py.

@jeromekelleher
Copy link
Member

jeromekelleher commented Aug 3, 2023

Is it time to drop h5py? It's years since anyone used the legacy formats, I'll bet, and they can install old versions of tskit if needs be.

@benjeffery
Copy link
Member Author

Ok, so after updating the 32bit docker image as it was on 3.7 and that was causing issues, numba now won't build as it needs llvm. However it needs specifically llvm version 10, which is no longer in the main ubuntu ppa.
On searching I see I should be able to get it from universe: https://pkgs.org/download/llvm-10
Will try that tomorrow.

@jeromekelleher
Copy link
Member

Oh jeez, fun times

@jeromekelleher
Copy link
Member

An alternative here might be to use the same workaround we have for 311 and skip the tests that require lshmm

@benjeffery benjeffery force-pushed the fix-32bit-ci branch 2 times, most recently from 36a7057 to bc03a32 Compare August 4, 2023 17:20
@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #2811 (766ba72) into main (bef0b4a) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2811      +/-   ##
==========================================
+ Coverage   89.95%   89.97%   +0.01%     
==========================================
  Files          29       30       +1     
  Lines       29263    29319      +56     
  Branches     5697     5706       +9     
==========================================
+ Hits        26324    26380      +56     
  Misses       1669     1669              
  Partials     1270     1270              
Flag Coverage Δ
c-tests 86.49% <ø> (+<0.01%) ⬆️
lwt-tests 80.78% <ø> (+0.65%) ⬆️
python-c-tests 67.83% <ø> (+0.71%) ⬆️
python-tests 99.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bef0b4a...766ba72. Read the comment docs.

@benjeffery benjeffery marked this pull request as ready for review August 4, 2023 18:21
@benjeffery
Copy link
Member Author

Went a bit round the houses here, but this seems to work for now.

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Aug 4, 2023
@mergify mergify bot merged commit 71f3e3f into tskit-dev:main Aug 4, 2023
21 checks passed
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Aug 4, 2023
@benjeffery benjeffery deleted the fix-32bit-ci branch September 21, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants