-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 32bit CI #2811
Fix 32bit CI #2811
Conversation
Is it time to drop h5py? It's years since anyone used the legacy formats, I'll bet, and they can install old versions of tskit if needs be. |
9a7d308
to
2771011
Compare
Ok, so after updating the 32bit docker image as it was on 3.7 and that was causing issues, |
Oh jeez, fun times |
An alternative here might be to use the same workaround we have for 311 and skip the tests that require lshmm |
36a7057
to
bc03a32
Compare
bc03a32
to
766ba72
Compare
Codecov Report
@@ Coverage Diff @@
## main #2811 +/- ##
==========================================
+ Coverage 89.95% 89.97% +0.01%
==========================================
Files 29 30 +1
Lines 29263 29319 +56
Branches 5697 5706 +9
==========================================
+ Hits 26324 26380 +56
Misses 1669 1669
Partials 1270 1270
Flags with carried forward coverage won't be shown. Click here to find out more. see 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Went a bit round the houses here, but this seems to work for now. |
Latest cython breaks compilation of h5py.