Add accessible name to navigation icon links #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently these links lack an accessible name at large screen sizes (as their actual text content is set in the `<small class="d-lg-none ...">`). Adding `aria-label` to the links themselves explicitly circumvents this problem. Additionally, this fixes the visible text for the "Twitter" link.
|
Could you also check the theme toggler in case we are missing anything? And/or our other Thanks again! |
|
Theme toggler is fine (and already has appropriate |
|
Didn't see any other problematic instances where |
XhmikosR
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently these links lack an accessible name at large screen sizes (as their actual text content is set in the
<small class="d-lg-none ...">). Addingaria-labelto the links themselves explicitly circumvents this problem.Additionally, this fixes the visible text for the "Twitter" link.
Preview: https://deploy-preview-442--bootstrapblog.netlify.app/