fix(pam/gdm): Fix and test handling of gdm qrcode regeneration #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
=======================================
Coverage 84.39% 84.40%
=======================================
Files 77 77
Lines 6691 6713 +22
Branches 75 75
=======================================
+ Hits 5647 5666 +19
- Misses 732 734 +2
- Partials 312 313 +1 ☔ View full report in Codecov by Sentry. |
3v1n0
force-pushed
the
qrcode-regenerate-cleanups
branch
7 times, most recently
from
b3ab93c
to
5e0edc5
Compare
|
I'll convert this to draft after what we discussed during the meeting regarding splitting the content into different PRs. |
3v1n0
force-pushed
the
qrcode-regenerate-cleanups
branch
3 times, most recently
from
58130e7
to
f1bb410
Compare
We already write a similar output in conversation, and that's enough
…ction in such case If we're already about to fail because of a timeout don't cleanup the transaction because we may end up stopping ongoing conversations which will lead to a panic, without clear explaination
This is an expectation, not really something we're doing in the test so change the value as expected
Since we are sharing the daemon we should not reuse the same user multiple time, so generate them based on the test name to avoid even manual clashes
In gdm when the authentication stage is changed we reset the currently svaed states, so do it also in the integration test mock to respect what the UI would do
Sometimes we may want to respond to a specific gdm event with multiple poll responses, to allow this, without refactor the world, we can just create a simple fake event and use its type as a counter for the events we want to group. When preceding events with this fake event, then the following N events will be added to the poll responses
Cancellation needs to be possible everytime we're in challenge mode, but this is handled already by the authentication backend so don't bother adding the logic here. Since in this way we'll prevent being able to cancel authentications that are in "wait" state and so when we're not anymore waiting for user authentication request, but only for the broker reply.
After this happens we're gonna receive a further start authentication event, so we need to stop considering the model being in auth phase
When waiting we may want to be able to cancel it, so support it
3v1n0
force-pushed
the
qrcode-regenerate-cleanups
branch
from
f1bb410
to
fe1e2d5
Compare
denisonbarbosa
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
reselectAuthModeis properly handled by the gdm model, following what the others model doUDENG-3126