-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pam/gdm): Fix and test handling of gdm qrcode regeneration #402
Commits on Jul 3, 2024
-
pam/gdm/extension: Do not write debug output twice
We already write a similar output in conversation, and that's enough
Configuration menu - View commit details
-
Copy full SHA for 8e0e46e - Browse repository at this point
Copy the full SHA 8e0e46eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 023c6ce - Browse repository at this point
Copy the full SHA 023c6ceView commit details -
pam/integration-tests/gdm: Increase timeout and do not end Pam transa…
…ction in such case If we're already about to fail because of a timeout don't cleanup the transaction because we may end up stopping ongoing conversations which will lead to a panic, without clear explaination
Configuration menu - View commit details
-
Copy full SHA for 4974081 - Browse repository at this point
Copy the full SHA 4974081View commit details -
pam/integration-tests/gdm: Rename authModeIDs to wantAuthModeIDs
This is an expectation, not really something we're doing in the test so change the value as expected
Configuration menu - View commit details
-
Copy full SHA for a1b8127 - Browse repository at this point
Copy the full SHA a1b8127View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05c533b - Browse repository at this point
Copy the full SHA 05c533bView commit details -
pam/integration-tests/gdm: Always use unique user names in tests
Since we are sharing the daemon we should not reuse the same user multiple time, so generate them based on the test name to avoid even manual clashes
Configuration menu - View commit details
-
Copy full SHA for 7a77d33 - Browse repository at this point
Copy the full SHA 7a77d33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0153852 - Browse repository at this point
Copy the full SHA 0153852View commit details -
pam/integration-tests/gdm: Mimic more the gdm behavior on auth events
In gdm when the authentication stage is changed we reset the currently svaed states, so do it also in the integration test mock to respect what the UI would do
Configuration menu - View commit details
-
Copy full SHA for 58f0335 - Browse repository at this point
Copy the full SHA 58f0335View commit details -
pam/gdm_test: Support replying to a GDM event with multiple events
Sometimes we may want to respond to a specific gdm event with multiple poll responses, to allow this, without refactor the world, we can just create a simple fake event and use its type as a counter for the events we want to group. When preceding events with this fake event, then the following N events will be added to the poll responses
Configuration menu - View commit details
-
Copy full SHA for e82ae9e - Browse repository at this point
Copy the full SHA e82ae9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ac89c5 - Browse repository at this point
Copy the full SHA 5ac89c5View commit details -
pam/gdmmodel: Support cancelling authentication all the times
Cancellation needs to be possible everytime we're in challenge mode, but this is handled already by the authentication backend so don't bother adding the logic here. Since in this way we'll prevent being able to cancel authentications that are in "wait" state and so when we're not anymore waiting for user authentication request, but only for the broker reply.
Configuration menu - View commit details
-
Copy full SHA for f4ed03c - Browse repository at this point
Copy the full SHA f4ed03cView commit details -
pam/gdmmodel: Reset the waiting authentication on reselect auth mode
After this happens we're gonna receive a further start authentication event, so we need to stop considering the model being in auth phase
Configuration menu - View commit details
-
Copy full SHA for c912c14 - Browse repository at this point
Copy the full SHA c912c14View commit details -
pam/client-dummy: Add support for cancelling isAuthenticated request
When waiting we may want to be able to cancel it, so support it
Configuration menu - View commit details
-
Copy full SHA for 7c4e2e4 - Browse repository at this point
Copy the full SHA 7c4e2e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fe1e2d5 - Browse repository at this point
Copy the full SHA fe1e2d5View commit details