Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examplebroker): Improve wording for the regenerate code button label #408

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix(examplebroker): Improve wording for the regenerate code button label #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37f6d56
pam/integration-test/cli: Increase terminal height to support bigger …
3v1n0 Jul 2, 2024
88dc05e
examplebroker: Improve wording for the regenerate code button label
3v1n0 Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion examplebroker/broker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ func getSupportedModes(sessionInfo sessionInfo, supportedUILayouts []map[string]
"type": "qrcode",
"label": modeLabel,
"wait": "true",
"button": "regenerate QR code",
"button": "Regenerate code",
}),
}

Expand Down
30 changes: 27 additions & 3 deletions pam/integration-tests/testdata/TestCLIAuthenticate/golden/authenticate_user_with_qr_code
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@









Expand Down Expand Up @@ -72,6 +75,9 @@ Gimme your password









Expand Down Expand Up @@ -112,6 +118,9 @@ Gimme your password









Expand Down Expand Up @@ -140,7 +149,10 @@ Scan the qrcode or enter the code in the login page
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
1337

[ regenerate QR code ]
[ Regenerate code ]






Expand Down Expand Up @@ -180,7 +192,10 @@ Scan the qrcode or enter the code in the login page
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
1337

[ regenerate QR code ]
[ Regenerate code ]






Expand Down Expand Up @@ -220,7 +235,10 @@ Scan the qrcode or enter the code in the login page
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
1337

[ regenerate QR code ]
[ Regenerate code ]






Expand Down Expand Up @@ -276,6 +294,9 @@ PAM AcctMgmt() exited with success






────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -316,4 +337,7 @@ PAM AcctMgmt() exited with success






────────────────────────────────────────────────────────────────────────────────
24 changes: 24 additions & 0 deletions ...gration-tests/testdata/TestCLIAuthenticate/golden/authenticate_user_with_qr_code_in_a_tty
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@









Expand Down Expand Up @@ -72,6 +75,9 @@ Gimme your password









Expand Down Expand Up @@ -112,6 +118,9 @@ Gimme your password









Expand Down Expand Up @@ -156,6 +165,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

[ Regenerate code ]


────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -196,6 +208,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

[ Regenerate code ]


────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -236,6 +251,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

[ Regenerate code ]


────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -276,6 +294,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

PAM Authenticate() for user "user-integration-qr-code-tty" exited with success
didrocks marked this conversation as resolved.
Show resolved Hide resolved
PAM AcctMgmt() exited with success
>
────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -316,4 +337,7 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

PAM Authenticate() for user "user-integration-qr-code-tty" exited with success
PAM AcctMgmt() exited with success
>
────────────────────────────────────────────────────────────────────────────────
24 changes: 24 additions & 0 deletions ...tests/testdata/TestCLIAuthenticate/golden/authenticate_user_with_qr_code_in_a_tty_session
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@









Expand Down Expand Up @@ -72,6 +75,9 @@ Gimme your password









Expand Down Expand Up @@ -112,6 +118,9 @@ Gimme your password









Expand Down Expand Up @@ -156,6 +165,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

[ Regenerate code ]


────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -196,6 +208,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

[ Regenerate code ]


────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -236,6 +251,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

[ Regenerate code ]


────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -276,6 +294,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

PAM Authenticate() for user "user-integration-qr-code-tty-session" exited with success
PAM AcctMgmt() exited with success
>
────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -316,4 +337,7 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

PAM Authenticate() for user "user-integration-qr-code-tty-session" exited with success
PAM AcctMgmt() exited with success
>
────────────────────────────────────────────────────────────────────────────────
24 changes: 24 additions & 0 deletions ...ration-tests/testdata/TestCLIAuthenticate/golden/authenticate_user_with_qr_code_in_screen
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@









Expand Down Expand Up @@ -72,6 +75,9 @@ Gimme your password









Expand Down Expand Up @@ -112,6 +118,9 @@ Gimme your password









Expand Down Expand Up @@ -156,6 +165,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

[ Regenerate code ]


────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -196,6 +208,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

[ Regenerate code ]


────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -236,6 +251,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

[ Regenerate code ]


────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -276,6 +294,9 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

PAM Authenticate() for user "user-integration-qr-code-screen" exited with success
PAM AcctMgmt() exited with success
>
────────────────────────────────────────────────────────────────────────────────
> if [ -v AUTHD_PAM_CLI_TERM ]; then export TERM=${AUTHD_PAM_CLI_TERM}; fi
> ./pam_authd login socket=${AUTHD_TESTS_CLI_AUTHENTICATE_TESTS_SOCK}
Expand Down Expand Up @@ -316,4 +337,7 @@ Scan the qrcode or enter the code in the login page
██████████████████████████████████████████████████████████████████
1337

PAM Authenticate() for user "user-integration-qr-code-screen" exited with success
PAM AcctMgmt() exited with success
>
────────────────────────────────────────────────────────────────────────────────