fix(examplebroker): Improve wording for the regenerate code button label #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…QR's When using the qrcode for tty the vertical space is not enough to show all the view items, so increase the vertical space so that both the button and the exit message are shown
The user is allowed to regenerate the login code not the QR code, so improve the wording here. Regenerate the golden files based on that
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #408 +/- ##
==========================================
- Coverage 84.39% 84.32% -0.08%
==========================================
Files 77 77
Lines 6691 6691
Branches 75 75
==========================================
- Hits 5647 5642 -5
- Misses 732 733 +1
- Partials 312 316 +4 ☔ View full report in Codecov by Sentry. |
denisonbarbosa
approved these changes
Jul 2, 2024
didrocks
reviewed
Jul 3, 2024
...ntegration-tests/testdata/TestCLIAuthenticate/golden/authenticate_user_with_qr_code_in_a_tty
Show resolved
Hide resolved
didrocks
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user is allowed to regenerate the login code not the QR code, so
improve the wording here.
Regenerate the golden files based on that
This is not strictly needed, but it's better to align with ubuntu/authd-oidc-brokers#47