UCAN JWT canonicalization #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdata
force-pushed
the
feature/canonicalization
branch
from
670d31a
to
0fbe9ea
Compare
This was referenced Sep 30, 2022
|
Thank you for the live walkthrough of the PR and codebase today @cdata. 🙏 Hopefully we'll have more valuable feedback in the future. |
justindotpub
approved these changes
Oct 3, 2022
justindotpub
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces support for UCAN-IPLD and canonical JWT encoding. UCAN-IPLD depends in part on modifications to the spec that were introduced in 0.9; so, this change also includes the parts of 0.9 that were necessary to implement UCAN-IPLD. However, this change does not transition us completely to conformance with 0.9. The following issues were filed to cover the remaining ground before we have fully implemented 0.9: #22, #23, #24, #25 and #27.
The changes introduced that bring us partially towards 0.9 include:
prffield now uses CIDs instead of nested JWT token stringsnbfield is supported inUcanIpldcapabilities (even though it is ignored in theUcanrepresentation)In addition to support for UCAN-IPLD, some bugs have been fixed. Most notably, #18 was addressed by changing how we generate the
nncfield value. Additionally, all tests now run in both native and web browser environments on CI (previously, only key support tests ran in a browser). Also, browser tests now run inside of headless Chrome in the Github Actions runner. This is both more reliable, and moves us away from using my personal Browser Stack account for those tests 😅Fixes #20
Fixes #18
Fixes #9