Skip to content

Add type checking changes#364

Closed
lispandfound wants to merge 1 commit intotesting_infra_refactorfrom
type_checking
Closed

Add type checking changes#364
lispandfound wants to merge 1 commit intotesting_infra_refactorfrom
type_checking

Conversation

@lispandfound
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lispandfound, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refining the project's build and dependency management processes. It introduces configuration for deptry to improve type-checking and dependency analysis by correctly categorizing development dependencies. Additionally, it optimizes the project's distribution by specifying exclusions in MANIFEST.in and adjusting package data settings, aiming for a more efficient and accurate packaging of the project.

Highlights

  • Dependency Management: Configured the deptry tool in pyproject.toml to correctly identify development dependency groups (test, dev, types). This enhances the accuracy of dependency analysis by ensuring that development-specific dependencies are not flagged as unused.
  • Package Distribution Control: Introduced a MANIFEST.in file to explicitly exclude non-essential directories and files (like tests, .github, wiki, and uv.lock) from the project's distribution package, leading to a leaner build.
  • Packaging Data Adjustment: Removed the [tool.setuptools.package-data] configuration from pyproject.toml, which previously included qcore/registry/registry.txt as package data. This change streamlines the packaging process, potentially indicating that this file is no longer needed in the distribution or is handled differently.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/deptry.yml
    • .github/workflows/pytest.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@lispandfound lispandfound deleted the type_checking branch January 7, 2026 22:20
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces changes to the project's packaging and dependency checking configuration. A MANIFEST.in file has been added to control the contents of the source distribution, and configuration for the deptry tool has been included. My review has identified a potentially critical issue where package data is removed, which could break the library for users. I've also provided a suggestion to improve the new MANIFEST.in file for correctness.

pyproject.toml Outdated
Comment on lines -43 to -45
[tool.setuptools.package-dir]
qcore = "qcore"

[tool.setuptools.package-data]
"qcore" = ["registry/registry.txt"]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change removes qcore/registry/registry.txt from the distributed package. If this file is required at runtime by the qcore library, its removal will likely cause runtime errors for users of the package. This change seems unrelated to the PR's goal of adding type checking and might be accidental. Please verify if this file is no longer needed. If it is, this removal should be reverted.

prune tests
prune .github
prune wiki
prune uv.lock
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The prune command is intended for directories. To exclude a single file like uv.lock, the exclude command should be used. This ensures the file is correctly excluded from the source distribution.

exclude uv.lock

@lispandfound lispandfound restored the type_checking branch January 7, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant