Add type checking changes#364
Conversation
Summary of ChangesHello @lispandfound, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on refining the project's build and dependency management processes. It introduces configuration for Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces changes to the project's packaging and dependency checking configuration. A MANIFEST.in file has been added to control the contents of the source distribution, and configuration for the deptry tool has been included. My review has identified a potentially critical issue where package data is removed, which could break the library for users. I've also provided a suggestion to improve the new MANIFEST.in file for correctness.
pyproject.toml
Outdated
| [tool.setuptools.package-dir] | ||
| qcore = "qcore" | ||
|
|
||
| [tool.setuptools.package-data] | ||
| "qcore" = ["registry/registry.txt"] | ||
|
|
There was a problem hiding this comment.
This change removes qcore/registry/registry.txt from the distributed package. If this file is required at runtime by the qcore library, its removal will likely cause runtime errors for users of the package. This change seems unrelated to the PR's goal of adding type checking and might be accidental. Please verify if this file is no longer needed. If it is, this removal should be reverted.
| prune tests | ||
| prune .github | ||
| prune wiki | ||
| prune uv.lock |
No description provided.