Skip to content

Add type checking changes #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lispandfound wants to merge 1 commit into from
Closed

Add type checking changes #364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions .github/workflows/deptry.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,5 @@ jobs:
python-version: "3.13"
- name: Setup uv
uses: astral-sh/setup-uv@v5
- run: uv sync --dev --all-extras
# Install deptry
- run: uv pip install deptry
# Run deptry to check that all dependencies are present.
- run: uv run deptry . -ddg test,dev,types
- run: uv sync --all-extras
- run: uv run deptry .
8 changes: 3 additions & 5 deletions .github/workflows/pytest.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@ jobs:
enable-cache: true

- name: Install the project
run: uv sync --all-extras --dev
run: uv sync --all-extras

- name: Run tests
run: |
source .venv/bin/activate
pytest --cov=qcore --cov-report=html tests
run: uv run pytest --cov=qcore --cov-report=html tests

- name: Upload coverage data
uses: actions/upload-artifact@v4
Expand All @@ -46,7 +44,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: 3.12
python-version: 3.13

- name: Install dependencies
run: |
Expand Down
4 changes: 4 additions & 0 deletions MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
prune tests
prune .github
prune wiki
prune uv.lock
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The prune command is intended for directories. To exclude a single file like uv.lock, the exclude command should be used. This ensures the file is correctly excluded from the source distribution.

exclude uv.lock

6 changes: 3 additions & 3 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ test = ["pytest", "hypothesis[numpy]", "pytest-cov"]
types = ["pandas-stubs", "scipy-stubs", "types-PyYAML"]
dev = ["ruff", "deptry", "ty"]

[tool.deptry]
pep621_dev_dependency_groups = ["test", "dev", "types"]

[tool.coverage.run]
omit = ["qcore/constants.py", "qcore/formats.py"]

Expand All @@ -40,9 +43,6 @@ omit = ["qcore/constants.py", "qcore/formats.py"]
[tool.setuptools.package-dir]
qcore = "qcore"

[tool.setuptools.package-data]
"qcore" = ["registry/registry.txt"]

Comment on lines -43 to -45
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change removes qcore/registry/registry.txt from the distributed package. If this file is required at runtime by the qcore library, its removal will likely cause runtime errors for users of the package. This change seems unrelated to the PR's goal of adding type checking and might be accidental. Please verify if this file is no longer needed. If it is, this removal should be reverted.

[tool.ruff.lint]
extend-select = [
# isort imports
Expand Down
Loading
Loading