Skip to content

Fixes Officer Parser failing when encountering a bad Google Drive Link#784

Merged
smalex-z merged 1 commit intomainfrom
officer-parser-fix
Apr 22, 2025
Merged

Fixes Officer Parser failing when encountering a bad Google Drive Link#784
smalex-z merged 1 commit intomainfrom
officer-parser-fix

Conversation

@smalex-z
Copy link
Copy Markdown
Contributor

@smalex-z smalex-z commented Apr 14, 2025

Overview

Resolves #N/A

Deploy Preview:

Changes

Previously a bad google drive link that still matched our regex expression would cause officer-parser.mjs to fail on build. This PR resolves that.

Testing

Run npm run build and observe if any errors occur. Check whether the officers page loads properly.

Possible Changes

Checklist

  • Code follows the project's style guidelines.
  • Documentation has been updated where necessary.
  • All checks pass and deploy builds with no errors.

@smalex-z smalex-z requested a review from katelynsyu April 14, 2025 03:20
@smalex-z smalex-z mentioned this pull request Apr 14, 2025
@Brendan-Staines Brendan-Staines self-requested a review April 22, 2025 01:56
Copy link
Copy Markdown
Contributor

@Brendan-Staines Brendan-Staines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@smalex-z smalex-z merged commit 8cd8a93 into main Apr 22, 2025
8 checks passed
@smalex-z smalex-z deleted the officer-parser-fix branch April 22, 2025 02:28
@smalex-z smalex-z mentioned this pull request Apr 29, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants