Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sfitz nftest assertions #235

Merged
merged 8 commits into from
Oct 2, 2023
Merged

Sfitz nftest assertions #235

merged 8 commits into from
Oct 2, 2023

Conversation

sorelfitzgibbon
Copy link
Contributor

@sorelfitzgibbon sorelfitzgibbon commented Sep 25, 2023

Description

Add assertions to nftest: compares actual to expected output

Testing Results

output: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions

nftest run a_mini-all-tools-std-input

original run:

output/hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/a_mini-all-tools-std-input-1
log: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/log-nftest-20230926T152143Z.log

post main merge:

output/hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/a_mini-all-tools-std-input
log: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/log-nftest-20230928T021502Z.log
slurm log: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/slurm-69085.out

nftest run a_mini-somaticsniper

log: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/log-nftest-20230925T223258Z.log

nftest run a_mini-strelka2

log: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/log-nftest-20230925T223430Z.log

nftest run a_mini-mutect2

log: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/log-nftest-20230925T223856Z.log

nftest run a_mini-muse

log: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/log-nftest-20230925T224243Z.log

nftest run a_mini-mutect2-multiple-samples

log: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/log-nftest-20230925T224332Z.log

nftest run a_mini-mutect2-tumor-only

log: /hot/software/pipeline/pipeline-call-sSNV/Nextflow/development/unreleased/sfitz-nftest-assertions/log-nftest-20230925T224851Z.log

Checklist

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have reviewed the Nextflow pipeline standards.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added my name to the contributors listings in the manifest block in the nextflow.config as part of this pull request; I am listed already, or do not wish to be listed. (This acknowledgement is optional.)

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)

  • I have tested the pipeline on at least one A-mini sample.

@sorelfitzgibbon
Copy link
Contributor Author

@yashpatel6 main has been merged and branch retested. Ready to go methinks.

yashpatel6
yashpatel6 previously approved these changes Sep 28, 2023
Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Anything else to add @maotian06 ?

@tyamaguchi-ucla
Copy link
Contributor

@yashpatel6 Not related to this PR but do we want to consider adding a CODEOWNERS to this pipeline?

@yashpatel6
Copy link
Contributor

@yashpatel6 Not related to this PR but do we want to consider adding a CODEOWNERS to this pipeline?

We definitely should, I've opened an issue to add this

@yashpatel6 yashpatel6 dismissed their stale review September 29, 2023 20:20

Quoting for arguments

Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting to account for spaces

test/assert_vcf.sh Outdated Show resolved Hide resolved
test/assert_vcf.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maotian06 Anything else to add?

@tyamaguchi-ucla
Copy link
Contributor

Quoting to account for spaces

Just wondering if this is something we can catch by GitHub action (linter) or not that straightforward? @yashpatel6
https://www.shellcheck.net/wiki/SC2086

@yashpatel6
Copy link
Contributor

Quoting to account for spaces

Just wondering if this is something we can catch by GitHub action (linter) or not that straightforward? @yashpatel6 https://www.shellcheck.net/wiki/SC2086

If the shellcheck linter was added to our cicd linter, it would get caught like any other linter errors with other languages; I opened an issue for adding shell script linting to cicd

Copy link
Contributor

@maotian06 maotian06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!!

@sorelfitzgibbon sorelfitzgibbon merged commit 0532766 into main Oct 2, 2023
1 check passed
@sorelfitzgibbon sorelfitzgibbon deleted the sfitz-nftest-assertions branch October 2, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants